Date: Sun, 12 May 2013 15:02:11 +0930 From: Shane Ambler <FreeBSD@ShaneWare.Biz> To: Raphael Kubo da Costa <rakuco@FreeBSD.org> Cc: freebsd-ports-bugs@FreeBSD.org, bug-followup@FreeBSD.org Subject: Re: ports/178505: [maintainer update] for graphics/openimageio Message-ID: <518F295B.4040501@ShaneWare.Biz> In-Reply-To: <201305112110.r4BLA1Vs001652@freefall.freebsd.org> References: <201305112110.r4BLA1Vs001652@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/05/2013 06:38, Raphael Kubo da Costa wrote: > Is the change to thread.h supposed to work on non-amd64 FreeBSD? Has > the patch been sent upstream? Short - yes and yes. Long - The patch originated with the discovery that i386 version crashed using tbb. The addition of arch=i586 to cflags enabled the use of gcc atomics. This was merged into the cmake files (src/cmake/platform.cmake) in 1.1.6 and taken out of the port makefile. 1.1.6 also included the removal of the freebsd condition in thread.h and by Larry Gritz's choice it was replaced with a test that left gcc atomics off if tbb was turned on. Disabling gcc atomics when tbb is on turned out to be a performance hit and 1.1.7 replaced the freebsd condition instead of removing the tbb test. I have submitted an issue for it (instead of a pull request) which seems to be the slow way of getting a change. While 1.1.8 appeared to be cli tools fixes and 1.1.9 was only docs, I don't want to drop behind so updating here with the patch.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?518F295B.4040501>