Date: Thu, 20 Jun 2013 01:51:53 +0200 From: Nikos Vassiliadis <nvass@gmx.com> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: Mikolaj Golub <trociny@FreeBSD.org>, freebsd-pf@freebsd.org Subject: Re: de-virtualize pf sysctls Message-ID: <51C24419.3020806@gmx.com> In-Reply-To: <20130619133912.GD1214@glebius.int.ru> References: <51B33B8B.9050006@gmx.com> <51B344B8.9090109@gmx.com> <20130612185150.GA6553@gmail.com> <51BD9DF3.1080808@gmx.com> <20130619133912.GD1214@glebius.int.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On 06/19/2013 03:39 PM, Gleb Smirnoff wrote: > On Sun, Jun 16, 2013 at 01:13:55PM +0200, Nikos Vassiliadis wrote: > N> >>> Please review this patch. These two variables are RO-tunables and > N> >>> cannot be changed at runtime. As such, it is not useful to > N> >>> virtualize them. > N> > > N> > This looks correct to me. Also, it looks like V_pf_hashmask and > N> > V_pf_srchashmask can be de-virtualized then. > N> > N> Yes, taken care of on this version. I am not sure if I placed > N> properly pf_hashmask and pf_srchashmask in pfvar.h. > N> > N> Please review, thanks. > > Thanks, Nikos. > > I committed the patch to the branch projects/pf/head. Can you > please check out this branch and generate further pf+vimage related > diffs against it? > > Once we finish and stabilize it, I will merge the branch to head. > Nice, I will create patches against this branch then. Thanks too, Nikos
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51C24419.3020806>