Date: Sun, 22 Sep 2013 15:13:18 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: Bryan Drewery <bryan@shatow.net> Cc: Big Lebowski <spankthespam@gmail.com>, freebsd-ports <freebsd-ports@freebsd.org> Subject: Re: Help in testing Basho Riak port Message-ID: <311A15A6-14C6-4BDC-97FB-BD731B882E47@FreeBSD.org> In-Reply-To: <20130920203737.GE74496@admin.xzibition.com> References: <CAHcXP%2Be15099FK7ch3NhktHXJKcSL%2BstANhSSZ-zwfOtB6%2BLfA@mail.gmail.com> <20130920203737.GE74496@admin.xzibition.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_02ACF6F3-9A4C-4FD4-9993-3252A0703060 Content-Type: multipart/mixed; boundary="Apple-Mail=_EA3BF7BB-AD21-4D29-9CB5-90EF0B611C9D" --Apple-Mail=_EA3BF7BB-AD21-4D29-9CB5-90EF0B611C9D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On Sep 20, 2013, at 22:37, Bryan Drewery <bryan@shatow.net> wrote: > On Fri, Sep 20, 2013 at 06:57:52PM +0100, Big Lebowski wrote: >> Hi list! >>=20 >> I've been working for couple last days on porting Basho Riak database >> (latest version 1.4.2) and finally I think it is ready to be = presented: >> https://www.dropbox.com/s/2ztu2bdiip1u2un/riak.tgz >=20 > MASTER_SITES=3D = http://s3.amazonaws.com/downloads.basho.com/riak/1.4/1.4.2/ \ > = http://downloads.basho.com.s3.amazonaws.com/riak/1.4/1.4.2/ >=20 > Use ${PORTVERSION} instead of 1.4.2 >=20 > USES=3D ${GMAKE} >=20 > Use 'gmake', not ${GMAKE} here. >=20 > Fails to build on 8.3 i386: >=20 > db/version_set.cc:59: warning: this decimal constant is unsigned only = in ISO C90 > db/version_set.cc:59: warning: this decimal constant is unsigned only = in ISO C90 > db/version_set.cc:60: error: integer constant is too large for 'long' = type > db/version_set.cc:60: error: integer constant is too large for 'long' = type > db/version_set.cc:61: error: integer constant is too large for 'long' = type > db/version_set.cc:61: error: integer constant is too large for 'long' = type > db/version_set.cc:62: error: integer constant is too large for 'long' = type > db/version_set.cc:62: error: integer constant is too large for 'long' = type > table/filter_block.cc: In member function 'bool = leveldb::FilterBlockReader::KeyMayMatch(uint64_t, const = leveldb::Slice&)': > table/filter_block.cc:112: warning: comparison between signed and = unsigned integer expressions > util/env_posix.cc: In constructor = 'leveldb::<unnamed>::PosixEnv::PosixEnv()': > util/env_posix.cc:788: warning: unused variable 'ts' Yes, this only seems to occur when compiling the port with gcc, but the = constants in that array are not defined in a portable way. Please drop = the attached patch file in databases/riak/files/, that should fix it. = Maybe it should go upstream, even. -Dimitry --Apple-Mail=_EA3BF7BB-AD21-4D29-9CB5-90EF0B611C9D Content-Disposition: attachment; filename=patch-deps-eleveldb-c_src-leveldb-db-version_set.cc Content-Type: application/octet-stream; x-unix-mode=0644; name="patch-deps-eleveldb-c_src-leveldb-db-version_set.cc" Content-Transfer-Encoding: 7bit --- deps/eleveldb/c_src/leveldb/db/version_set.cc.orig 2013-08-29 23:03:04.000000000 +0200 +++ deps/eleveldb/c_src/leveldb/db/version_set.cc 2013-09-22 14:38:08.000000000 +0200 @@ -2,10 +2,12 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. See the AUTHORS file for names of contributors. +#define __STDC_CONSTANT_MACROS #include "db/version_set.h" #include <algorithm> #include <stdio.h> +#include <stdint.h> #include "db/filename.h" #include "db/log_reader.h" #include "db/log_writer.h" @@ -53,13 +55,13 @@ // WARNING: m_OverlappedFiles flags need to match config::kNumOverlapFiles ... until unified { - {10485760, 262144000, 57671680, 209715200, 0, 300000000, true}, - {10485760, 82914560, 57671680, 419430400, 0, 209715200, true}, - {10485760, 104371840, 57671680, 1006632960, 200000000, 314572800, false}, - {10485760, 125829120, 57671680, 4094304000, 3355443200, 419430400, false}, - {10485760, 147286400, 57671680, 41943040000, 33554432000, 524288000, false}, - {10485760, 188743680, 57671680, 419430400000, 335544320000, 629145600, false}, - {10485760, 220200960, 57671680, 4194304000000, 3355443200000, 734003200, false} + {UINT64_C(10485760), UINT64_C(262144000), INT64_C(57671680), UINT64_C( 209715200), UINT64_C( 0), UINT64_C(300000000), true}, + {UINT64_C(10485760), UINT64_C( 82914560), INT64_C(57671680), UINT64_C( 419430400), UINT64_C( 0), UINT64_C(209715200), true}, + {UINT64_C(10485760), UINT64_C(104371840), INT64_C(57671680), UINT64_C( 1006632960), UINT64_C( 200000000), UINT64_C(314572800), false}, + {UINT64_C(10485760), UINT64_C(125829120), INT64_C(57671680), UINT64_C( 4094304000), UINT64_C( 3355443200), UINT64_C(419430400), false}, + {UINT64_C(10485760), UINT64_C(147286400), INT64_C(57671680), UINT64_C( 41943040000), UINT64_C( 33554432000), UINT64_C(524288000), false}, + {UINT64_C(10485760), UINT64_C(188743680), INT64_C(57671680), UINT64_C( 419430400000), UINT64_C( 335544320000), UINT64_C(629145600), false}, + {UINT64_C(10485760), UINT64_C(220200960), INT64_C(57671680), UINT64_C(4194304000000), UINT64_C(3355443200000), UINT64_C(734003200), false} }; --Apple-Mail=_EA3BF7BB-AD21-4D29-9CB5-90EF0B611C9D Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii --Apple-Mail=_EA3BF7BB-AD21-4D29-9CB5-90EF0B611C9D-- --Apple-Mail=_02ACF6F3-9A4C-4FD4-9993-3252A0703060 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.20 (Darwin) iEYEARECAAYFAlI+7P0ACgkQsF6jCi4glqNp9wCePckYZJZgK4VYbXHm29F18BIC TT0AoPaHRETq3iibpVy+okmsVp4WUIVm =YAwL -----END PGP SIGNATURE----- --Apple-Mail=_02ACF6F3-9A4C-4FD4-9993-3252A0703060--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?311A15A6-14C6-4BDC-97FB-BD731B882E47>