Date: Mon, 23 Sep 2013 11:28:19 +0200 From: Pietro Cerutti <gahr@gahr.ch> To: Tijl Coosemans <tijl@FreeBSD.org> Cc: freebsd-ports@freebsd.org, David Wolfskill <david@catwhisker.org> Subject: Re: Help understanding ports tinderbox failure report? Message-ID: <20130923092819.GE25610@gahrfit.gahr.ch> In-Reply-To: <20130923111626.136d14f2@kalimero.tijl.coosemans.org> References: <20130923005528.GA1616@albert.catwhisker.org> <20130923080810.GC25610@gahrfit.gahr.ch> <20130923102353.3cd4cfb3@kalimero.tijl.coosemans.org> <20130923084600.GD25610@gahrfit.gahr.ch> <20130923111626.136d14f2@kalimero.tijl.coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--7uYPyRQQ5N0D02nI
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On 2013-Sep-23, 11:16, Tijl Coosemans wrote:
> On Mon, 23 Sep 2013 10:46:00 +0200 Pietro Cerutti wrote:
> > On 2013-Sep-23, 10:23, Tijl Coosemans wrote:
> >> On Mon, 23 Sep 2013 10:08:11 +0200 Pietro Cerutti wrote:
> >>> On 2013-Sep-22, 17:55, David Wolfskill wrote:
> >>>> Back in July, I filed PR ports/180642 (as the port maintainer for
> >>>> astro/gpsman) to update that port from 6.4.4 to 6.4.4.1.
> >>> [snip]
> >>>> I've attached a revised patch, to:
> >>>> * Perform the 6.4.4 -> 6.4.4.1 upgrade.
> >>>> * Replace the "USE_TK_RUN" (& "USE_TK_WRAPPER") with "USES+=3D tk:wr=
apper,run".
> >>>> * Avoid showing the pkg-message if NOPORTDOCS is defined.
> >>>=20
> >>> please find attached a revised patch, including:
> >>>=20
> >>> - the update to 6.4.4.1
> >>> - update to the new OPTIONS framework (s|NOPORTDOCS|!${PORTOPTIONS:MD=
OCS})
> >>> - install man pages along with docs
> >>> - fix wish and datadir paths in gpsman.tcl
> >>>=20
> >>> Approved?
> >>=20
> >> The tinderbox build also defined NOPORTDATA. This variable makes litt=
le
> >> sense, but you could support it in the do-install target (don't install
> >> ${PREFIX}/share/gpsman (aka ${DATADIR})).
> >=20
> > I see the problem. In this case, it makes little sense to avoid
> > installing PORTDATA for this port, as everything is in DATADIR,
> > including the script that is symlinked to ${PREFIX}/bin/gpsman, and the
> > port won't work without the stuff in DATADIR.
> >=20
> >> Since you converted NOPORTDOCS, could you also add OPTIONS_DEFINE=3DDO=
CS?
> >=20
> > i'm not sure it's common to add OPTIONS only for DOCS.
>=20
> It's supposed to be. The dialog won't appear if users set or unset the
> DOCS option in make.conf (just like adding NOPORTDOCS to make.conf before=
).
Can you please elaborate on this?
--=20
Pietro Cerutti
gahr@gahr.ch
PGP Public Key:
http://gahr.ch/pgp
--7uYPyRQQ5N0D02nI
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.21 (FreeBSD)
iEYEARECAAYFAlJACbIACgkQwMJqmJVx944o7ACg2/xx4NIcuKikr33q2VPtnf8X
CO0AnjibQQmNkwGZc3I4QhT37hA6FRAu
=a0OI
-----END PGP SIGNATURE-----
--7uYPyRQQ5N0D02nI--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130923092819.GE25610>