Date: Tue, 15 Oct 2013 09:54:14 -0400 From: Julio Merino <julio@meroh.net> To: "Simon J. Gerraty" <sjg@juniper.net> Cc: freebsd-testing@freebsd.org, Rui Paulo <rpaulo@fnop.net>, Garrett Cooper <yanegomi@gmail.com> Subject: Re: Refactoring of *.test.mk Message-ID: <CADyfeQVCTDmFqjpkkkOZcZDEQzTEf=h=RyTcTs2GPQx-XhHm6w@mail.gmail.com> In-Reply-To: <20131015062139.DAD595807E@chaos.jnpr.net> References: <CADyfeQVTx3LUo3Q-bcPPmG3Xx4TPtRcJB1%2Bzk6ms_-zz%2Box6eg@mail.gmail.com> <CADyfeQW5z6aWH1sfnGF5mbWGeHap-o4j7Y4ttqGRU5WDqMbABg@mail.gmail.com> <20131015062139.DAD595807E@chaos.jnpr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Oct 15, 2013 at 2:21 AM, Simon J. Gerraty <sjg@juniper.net> wrote:
> Thanks Julio,
>
> looks good.
Thanks for the reviews Simon and Rui.
> One nit; in hook-atf-run.diff and hook-kyua.diff I see:
[...]
> ATF_BUILD_CC?= ${DESTDIR}/usr/bin/cc
> ..
> TESTS_ENV+= ATF_BUILD_CC=${ATF_BUILD_CC}
> ..
OK, I've done this. And, at the same time, improved the way TESTS_ENV
is constructed by leaving the atf-specific bits in atf.test.mk and
moving the path handling to bsd.test.mk. PTAL.
I suspect that with 10 branched, we don't need approval from re@ for
submission at this point; is that correct?
That said, I think it's worth to merge this into 10 (now or after
release, doesn't matter much). Given that this touches yet-unused
files, it shouldn't be a major concern for re@. The reason for merging
into 10 is that it'd be nice if any future tests written in HEAD for
regressions encountered in 10 could be pulled up into the branch with
ease along the actual fixes.
Cheers,
--
Julio Merino / @jmmv
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADyfeQVCTDmFqjpkkkOZcZDEQzTEf=h=RyTcTs2GPQx-XhHm6w>