Date: Sun, 24 Nov 2013 23:48:54 -0500 From: Glen Barber <gjb@FreeBSD.org> To: Manfred Antar <null@pozo.com> Cc: freebsd-current@freebsd.org Subject: Re: Buildworld broken with WITHOUT_DYNAMICROOT=yes in src.conf Message-ID: <20131125044854.GC2310@glenbarber.us> In-Reply-To: <201311250441.rAP4freb002330@pozo.com> References: <201311250111.rAP1BuI0009520@pozo.com> <20131125011949.GC1627@glenbarber.us> <20131125012302.GD1627@glenbarber.us> <201311250129.rAP1TJfQ033437@pozo.com> <20131125041724.GA2310@glenbarber.us> <201311250441.rAP4freb002330@pozo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--CblX+4bnyfN0pR09 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Nov 24, 2013 at 08:41:48PM -0800, Manfred Antar wrote: > At 08:17 PM 11/24/2013, Glen Barber wrote: > >On Sun, Nov 24, 2013 at 05:29:14PM -0800, Manfred Antar wrote: > >> adding -lc_nonshared to LAAD enables me to build /bin and /sbin static= ally > >> /bin/csh/Makefile was the only one I had to change all the rest of /bi= n and /sbin built fine > >>=20 > > > >Hmm, I'm not sure if bin/csh/ should require -c_nonshared > >unconditionally. > > > >I've done some testing with WITHOUT_DYNAMICROOT=3D1, WITHOUT_ICONV=3D1, > >WITH_ICONV=3D1, WITH_DYNAMICROOT=3D1, and am getting different results w= ith > >regard to what iconv_*() are included... > > > >Glen > > > > >=20 > I think it only needs it if you want a static csh. > my src.conf : >=20 > #WITHOUT_DYNAMICROOT=3Dyes=20 > WITH_IDEA=3Dyes > # Don't die on warnings > NO_WERROR=3D > WERROR=3D > WITH_GCC=3Dyes > WITH_GNUCXX=3Dyes >=20 > can you some kind of conditional >=20 > if WITHOUT_DYNAMICROOT=3Dyes then LADD+=3D -lc_nonshared=20 >=20 Yes, that is what I am doing, but also getting unexpected results. Latest diff I tried is: Index: Makefile =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- Makefile (revision 258538) +++ Makefile (working copy) @@ -42,6 +42,9 @@ =20 DPADD=3D ${LIBTERMCAP} ${LIBCRYPT} LDADD=3D -ltermcap -lcrypt +.if ${MK_ICONV} !=3D "no" && ${MK_DYNAMICROOT} !=3D "yes" +LDADD+=3D -lc_nonshared +.endif =20 LINKS=3D ${BINDIR}/csh ${BINDIR}/tcsh =20 Glen --CblX+4bnyfN0pR09 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQIcBAEBCAAGBQJSkta2AAoJELls3eqvi17QEKIQAJOsKWk6mvly0m+Q5WcF7oZo JOX1hq7+qOE/UjJXpt5VD8xfCcz0rwwN+AArwdEwf6VWYc+670jgEgQ/GA3QqPhX 6vntEFZCtvIHY+YdSY+CKITuo7dR8iSF4UUvBDLo2/9rv6d8kt8vTfzTZceIx2b/ C7gRV8Thv88gYqLRepvc+ffrNlgTjXGHZhxbiL89QZNMXPHk6vrbfUtlazOlH0Pn +klsWWonvYrCmUtIXcHmCf1K/VSsmYpCAcBL81nHiXtHxHQAXaQTM6/njJnXoeQJ EqA95YNax2gtyaZIV0Ic3hv9CHJTIbLvp+rAsoe2y398r8WbbFeFzyA1Xb4/uSh1 fToBTmjZVcTXpcdJoO7esFfwSxQhGf4awcZ3FUjfzEtv20wIjz6MguPzYa8cW82X gMcPIB7UWtUhbHurXodXbf3iwaaMoD63aPyT6zSjlp0WDzD7Q0u1sfNtwzmO2Cd1 xC3mipxAF6aRomKNsEdTB5/qeyESmQq8/isdXSgI+cmzlBfSuSSeS8LCxfByqvbp Lot2nfaKsC3lCvFz0LkELOvxxBtdUUQPh4r70s9lSybiTPeWc6QKkymI8g5M9FK2 I6uh9rlfdNXv/2J1ZwfxvknTrefgJI1HBNt2UQgmqPK/q/edJ8nzCj35TopSx7n2 9Yxsk9pin8qMMDIKxo9m =0sNg -----END PGP SIGNATURE----- --CblX+4bnyfN0pR09--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131125044854.GC2310>