Date: Sun, 12 Jan 2014 09:08:27 +0100 From: Hans Petter Selasky <hps@bitfrost.no> To: Alex Goncharov <alex_goncharov_usa@yahoo.com>, freebsd-usb@FreeBSD.org, freebsd-gnats-submit@freebsd.org Subject: Re: usb/185628: usbd_req_re_enumerate set address failed USB_ERR_STALLED for Seagate USB drives between r259425 and r260321 Message-ID: <52D24D7B.3060204@bitfrost.no> In-Reply-To: <201401120610.s0C6A1Fx064199@freefall.freebsd.org> References: <201401120610.s0C6A1Fx064199@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 01/12/14 07:10, Alex Goncharov wrote: > The following reply was made to PR usb/185628; it has been noted by GNATS. > > From: Alex Goncharov <alex_goncharov_usa@yahoo.com> > To: "freebsd-gnats-submit@FreeBSD.org" <freebsd-gnats-submit@FreeBSD.org>, > Hans Petter Selasky <hps@bitfrost.no>, freebsd-usb@FreeBSD.org > Cc: > Subject: Re: usb/185628: usbd_req_re_enumerate set address failed USB_ERR_STALLED for Seagate USB drives between r259425 and r260321 > Date: Sat, 11 Jan 2014 21:58:02 -0800 (PST) > > --2120775178-1643984294-1389506282=:33519 > Content-Type: text/plain; charset=us-ascii > > ,-- On Fri, 1/10/14, Hans Petter Selasky <hps@bitfrost.no> wrote: > ,-- On 01/10/14 12:49, Alex Goncharov wrote: > >> Maybe; but think about the fact correlations: the fact of the two > >> system's upgrade, two identical Seagate units, and other HDDs being > >> non-stalled. > > > > If you are running EHCI, there has been no changes in the USB stack, > > Apparently, there have been; this is what causes the bogus error: > > ------------------------------------------------------------------------ > r259454 | hselasky | 2013-12-16 03:51:58 -0500 (Mon, 16 Dec 2013) | 11 lines > > MFC r244503 and r246565: > > Make sure all USB drivers allocate buffer memory > through the USB API and/or busdma. > > The following assumptions have been made: > umass - buffers passed from CAM/SCSI layer are OK > network - mbufs are OK. > > Some other nits while at it. > ------------------------------------------------------------------------ > > I am attaching the code difference for the two relevant files > > ---------------------------------------- > M sys/dev/usb/storage/ustorage_fs.c > M sys/dev/usb/usb_msctest.c > ---------------------------------------- > > in this change set, skipping the irrelevant 'sys/dev/usb/wlan' ones. > > Can this be fixed reasonably soon, please? (I miss my HDDs :) > Hi, Can you do "usbdump -i usbusX -s 65536 -vvv" where is X is the controller unit which the seagate drive attaches to, before and after reverting patch "259454". I need to see what the difference is in the USB level, because patch "259454" should not affect the protocol data only the timing. --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52D24D7B.3060204>