Date: Tue, 28 Jan 2014 19:33:22 -0500 From: J David <j.david.lists@gmail.com> To: freebsd-net@freebsd.org Subject: Re: Terrible NFS performance under 9.2-RELEASE? Message-ID: <CABXB=RQd%2BUQLvZ=Lf-yuG==Xss%2BNxGjZnBupVzM0b_QW9nuLRw@mail.gmail.com> In-Reply-To: <20140128234136.GJ13704@funkthat.com> References: <20140128002826.GU13704@funkthat.com> <1415339672.17282775.1390872779067.JavaMail.root@uoguelph.ca> <20140128021450.GY13704@funkthat.com> <CABXB=RTa_buG0k7oFaQcKpE0EFyS%2BpxMzx6aKCzXkP0tQ9As2g@mail.gmail.com> <20140128234136.GJ13704@funkthat.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jan 28, 2014 at 6:41 PM, John-Mark Gurney <jmg@funkthat.com> wrote: > It might be better to move most of m_getm's docs under m_getm2, and > document that m_getm is just m_getm2 w/ M_PKTHDR flag set. > > Could you also document that only M_PKTHDR and M_EOR are valid > flags for m_getm2? OK, try this: http://pastebin.com/39kwExsc > You are correct.. the problem is that the MLINK isn't setup in the > Makefile, so: > $ man m_append > No manual entry for m_append Oh drat, I just saw another one of those the other day and didn't make a note of it. Oh yeah, it's uma_zalloc_arg. Thanks, shell history! > It's common to use a macro when the change isn't complicated, i.e. > just adding a flag... Sure, it's a little unsettling that the man page is explicitly separated into macros and functions and this macro is the second entry in under "The functions are:." It's like seeing a library book shelved in the wrong section. Probably m_getm was a function for a long time and got turned into a macro when m_getm2 was born. The documentation was either not updated or intentionally left as-is. Since I didn't know which was the case, I've left it where it is for now. Thanks!
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CABXB=RQd%2BUQLvZ=Lf-yuG==Xss%2BNxGjZnBupVzM0b_QW9nuLRw>