Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 24 Feb 2014 08:51:39 -0800
From:      David Wolfskill <david@catwhisker.org>
To:        current@freebsd.org
Cc:        Hans Petter Selasky <hselasky@FreeBSD.org>
Subject:   [PATCH] Re: svn commit: r262439 - head/sys/dev/usb/input
Message-ID:  <20140224165139.GS1630@albert.catwhisker.org>
In-Reply-To: <201402241044.s1OAig7H062968@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--YqKeQn+qkMVHQmbT
Content-Type: multipart/mixed; boundary="/KohU7xR/z4Rz7fl"
Content-Disposition: inline


--/KohU7xR/z4Rz7fl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

I encountered an error during buildkernel:

=2E..
=3D=3D=3D> usb/atp (all)
--- atp.o ---
clang -O2 -pipe -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdi=
nc   -DHAVE_KERNEL_OPTION_HEADERS -include /common/S4/obj/usr/src/sys/CANAR=
Y/opt_global.h -I. -I@ -I@/contrib/altq -fno-common -gdwarf-2 -I/common/S4/=
obj/usr/src/sys/CANARY  -mno-aes -mno-avx -mno-mmx -mno-sse -msoft-float -f=
freestanding -fstack-protector -std=3Diso9899:1999 -Qunused-arguments  -fst=
ack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes =
 -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-po=
inter-sign -fformat-extensions  -Wmissing-include-dirs -fdiagnostics-show-o=
ption  -Wno-error-tautological-compare -Wno-error-empty-body  -Wno-error-pa=
rentheses-equality -Wno-unused-function   -c /usr/src/sys/modules/usb/atp/.=
=2E/../../dev/usb/input/atp.c
/usr/src/sys/modules/usb/atp/../../../dev/usb/input/atp.c:797:40: error: un=
used variable 'atp_sensor_data_interpreters' [-Werror,-Wunused-const-variab=
le]
static const sensor_data_interpreter_t atp_sensor_data_interpreters[TRACKPA=
D_FAMILY_MAX] =3D {
                                       ^
1 error generated.
*** [atp.o] Error code 1


The attached patch worked for me.

Now running:

FreeBSD 11.0-CURRENT #1172  r262439M/262439:1100009: Mon Feb 24 08:06:04 PS=
T 2014     root@localhost:/common/S4/obj/usr/src/sys/CANARY  i386

Peace,
david
--=20
David H. Wolfskill				david@catwhisker.org
Taliban: Evil cowards with guns afraid of truth from a 14-year old girl.

See http://www.catwhisker.org/~david/publickey.gpg for my public key.

--/KohU7xR/z4Rz7fl
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="atp.diff"
Content-Transfer-Encoding: quoted-printable

Index: sys/dev/usb/input/atp.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- sys/dev/usb/input/atp.c	(revision 262439)
+++ sys/dev/usb/input/atp.c	(working copy)
@@ -794,11 +794,6 @@
 static void	     atp_reset_buf(struct atp_softc *);
 static void	     atp_add_to_queue(struct atp_softc *, int, int, int, uint3=
2_t);
=20
-static const sensor_data_interpreter_t atp_sensor_data_interpreters[TRACKP=
AD_FAMILY_MAX] =3D {
-	[TRACKPAD_FAMILY_FOUNTAIN_GEYSER] =3D fg_interpret_sensor_data,
-	[TRACKPAD_FAMILY_WELLSPRING]      =3D wsp_interpret_sensor_data,
-};
-
 /* Device methods. */
 static device_probe_t  atp_probe;
 static device_attach_t atp_attach;

--/KohU7xR/z4Rz7fl--

--YqKeQn+qkMVHQmbT
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (FreeBSD)

iQJ8BAEBCgBmBQJTC3iaXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ4RThEMDY4QTIxMjc1MDZFRDIzODYzRTc4
QTY3RjlDOERFRjQxOTNCAAoJEIpn+cje9Bk7ikwP/RUiidDiU/aK3Kev3xUlgHAv
bl+LVQcIy9/DZ8wD3orGivKza7WG/YR0kdW53+up1+4X8nLJ8ek6yP0qSoJ5gQ1p
VkKnyVE7G4YU7Qrnki8HVsOzFFsmbV3ZuPC312p5Z4enK5gtgttIesD0vCNqJsiJ
TZbVl1CPmz+lu+rNwHUFyG2rVAxq9lCILAbWL4eM+HQPXDIk2gFEL3kuuTH4KzgA
HsEmeRKIDpLWN1ooSuTgS3M20a/wswBRYhKAySK1pdYjNCX5eSHAZT8tlAxrOA9i
9a3JuNEErrLjvI34fTznyNe8T1VcJdf8GGejETpzDySWBVB+/oA2hu7+3Nizoh0E
rn/Wqy7oQoy38Gmd8HX9OTVmRbgcPZKCUEMnfRcH0tJjyhFpjfRL5+3BW14uT0hF
GxO4peWyli2A945AJBmRAQhrESGjlf18AxRXRne85iz7Tx9EXV9xjJZcskEggOF8
w3QE4eeSxSkueReedzg4Zrb/CkZecd5hl+GUF7baCLKUuV24cPy53OE8pIVoCtqF
lauSDi8FbtnuOxY4/4OTbloe15IxseiFVLNDrm5rKX0w6whaN6kqyd2qWAjywsv6
Sa9lu05dtr6bHsGz1EJCGnt69oICqrge/nerF2uNNN6AR13Z0fx3BdnlV8V9T4kV
Bu936sfdHEZ7eUsLNBeR
=aRA0
-----END PGP SIGNATURE-----

--YqKeQn+qkMVHQmbT--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140224165139.GS1630>