Date: Sat, 9 Aug 2014 16:35:28 -0600 From: Warner Losh <imp@bsdimp.com> To: John-Mark Gurney <jmg@funkthat.com> Cc: Tim Kientzle <tim@kientzle.com>, freebsd-arm@FreeBSD.org, Fabien Thomas <fabient@FreeBSD.org>, Ian Lepore <ian@FreeBSD.org> Subject: Re: [CFR] mge driver / elf reloc Message-ID: <2F9FF1C2-7C87-4C5E-A829-9ACBCB0FF7A1@bsdimp.com> In-Reply-To: <20140809041425.GE83475@funkthat.com> References: <14D22EA6-B73C-47BA-9A86-A957D24F23B8@freebsd.org> <1405810447.85788.41.camel@revolution.hippie.lan> <20140720220514.GP45513@funkthat.com> <F6D53A17-FED0-4F08-BB5B-9F66C5AF5EF6@kientzle.com> <20140720231056.GQ45513@funkthat.com> <BDFA451C-D74E-4EA7-B1BA-F818E98AB372@freebsd.org> <1407536156.56408.412.camel@revolution.hippie.lan> <20140809041425.GE83475@funkthat.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_36106E6A-3B06-4118-9704-835FAF3D485A Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Aug 8, 2014, at 10:14 PM, John-Mark Gurney <jmg@funkthat.com> wrote: > Ian Lepore wrote this message on Fri, Aug 08, 2014 at 16:15 -0600: >> On Mon, 2014-07-21 at 10:40 +0200, Fabien Thomas wrote: >>> On 21 Jul 2014, at 01:10, John-Mark Gurney <jmg@funkthat.com> wrote: >>>=20 >>>> Tim Kientzle wrote this message on Sun, Jul 20, 2014 at 15:25 = -0700: >>>>>=20 >>>>> On Jul 20, 2014, at 3:05 PM, John-Mark Gurney <jmg@funkthat.com> = wrote: >>>>>=20 >>>>>> Ian Lepore wrote this message on Sat, Jul 19, 2014 at 16:54 = -0600: >>>>>>> Sorry to take so long to reply to this, I'm trying to get caught = up. I >>>>>>> see you've already committed the mge fixes. I think the ELF = alignment >>>>>>> fix looks good and should also be committed. >>>>>>=20 >>>>>> So, re the elf alignment... >>>>>>=20 >>>>>> I think we should get a set of macros that handle load/stores = to/from >>>>>> unaligned addresses that are transparent to the caller.... I = need >>>>>> these for some other code I'm writing...=20 >>>>>>=20 >>>>>> I thought Open/Net had these available, but I can't seem to find = them >>>>>> right now... >>>>>=20 >>>>> $ man 9 byteorder >>>>>=20 >>>>> is most of what you want, lacking only some aliases to pick >>>>> the correct macro for native byte order. >>>>=20 >>>> Um, those doesn't help if you want native endian order... >>>>=20 >>>> Also, only the enc/dec functions are documented to work on = non-aligned >>>> address, so that doesn't help in most cases... >>>=20 >>> Yes, having an API to read unaligned pointer is better than than = using local fix like in the patch. >>> Tell me if you add one and I can adapt the patch. >>>=20 >>> Fabien >>>=20 >>=20 >> So can we just get this patch committed as-is, and then maybe convert = it >> later to the much-desired "something better" that this discussion >> deteriorated into? >>=20 >> http://people.freebsd.org/~fabient/ARM/patch-arm_elf_alignfix >>=20 >> If you've ever wondered whether there are real costs to bikeshedding, >> this is an example of such. This relocation patch is the fix to the >=20 > Yes and no... Yes, this delayed it, but replys on improvement were > given (Warner's) and then no action was taken... >=20 > I want us to continue to take the better way than the quickest way... >=20 >> kernel module loading problem HPS has been having, and who knows how >> much time he had to waste debugging it. I know I spent 4 hours on it >> today before discovering that the problem was known and fixed, only = the >> fix isn't committed yet. >=20 > I agree w/ Warner that the conditional should be removed and we always > call load_ptr/store_ptr... The feedback was given quickly, but no reply was forthcoming. = Criticizing the feedback seems rather out of line. I=92ll commit something this weekend, but honestly the feedback wasn=92t = a bikeshed by any stretch of the imagination. Warner --Apple-Mail=_36106E6A-3B06-4118-9704-835FAF3D485A Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJT5qIwAAoJEGwc0Sh9sBEArLAQANY8tL8cvD7SzcfbLdzsczvc +l6q+2QlGnVNdzuA94NlvtmhxFe/DZ04GaLXv1IL4MFq9hP4SyWRa03R/whNPPWG l5NkGy28Ov5FgeO3FitzRRaFp+sRd0XuhRgiGshD/p54PiC9er03Z0pancA6lDFp 1mZz0EdAhj7zkbefKREaygQKlelCgo673wgCIJoGlpfqSbQqwKBYl3eLEMdKtjb7 c/QlMCCtjWwA1KbSpGzyc/q5HsV49av6IGlDInNWHTbkP8mXR/pxfDAR7zAj+Swi K87F0ccBwiwTzDtMxiCgd68Mp8g8H1eYiYqWBlhR3kNFqaSp7glg8GcemMVqTPQ1 JV/XHlcwy7k/qVOF4vNnW9b3irXLbwzH7hLGkWDdO9NYp8BaSpFPJZ6CqGWz9c1l VyrclznuEhszqgsiMqXFoNm9IBNoyINKUMTGduF4haw9Rkay9QhfEkH/UJ0qZ0EO K/ulJz0cxwo696Y67422nKxC3h4Ehk3Hxy11llhiHbhizESe708t6zssasdsITtG InkI/rDyEjbx/NcbzhDfo+gWxUE+fjHr08S1eBW+SMTnw43NzuWDebGLHB+gNlov hV9R1OBtdmDhTElIovVWKu7N1x7+zWOkTJQsbswZy4m3pRBXfFofyaGRM5rr4EX7 tDEVLWB78IgmQEpejc9R =p0dj -----END PGP SIGNATURE----- --Apple-Mail=_36106E6A-3B06-4118-9704-835FAF3D485A--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2F9FF1C2-7C87-4C5E-A829-9ACBCB0FF7A1>