Date: Sun, 7 Sep 2014 19:56:23 -0700 From: Adrian Chadd <adrian@freebsd.org> To: Glen Barber <gjb@freebsd.org> Cc: freebsd-current <freebsd-current@freebsd.org>, Garrett Cooper <yaneurabeya@gmail.com> Subject: Re: NO INET6 warning Message-ID: <CAJ-Vmom0Zq088TaobNNPzd0GP4zm%2B330kjCNm-vbvt=TOoD%2B3A@mail.gmail.com> In-Reply-To: <20140908023425.GF48287@hub.FreeBSD.org> References: <1410123815.10027.18.camel@bruno> <20140907210802.GA48287@hub.FreeBSD.org> <B83C39FA-AA8B-4A8D-9441-2BD1BAC380FC@gmail.com> <20140908023425.GF48287@hub.FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
No, because I may end up building a kernel that has no INET6 for a cut
down platform that has no src.conf option set.
-a
On 7 September 2014 19:34, Glen Barber <gjb@freebsd.org> wrote:
> On Sun, Sep 07, 2014 at 03:34:35PM -0700, yaneurabeya@gmail.com wrote:
>> On Sep 7, 2014, at 14:08, Glen Barber <gjb@FreeBSD.org> wrote:
>>
>> > On Sun, Sep 07, 2014 at 02:03:35PM -0700, Sean Bruno wrote:
>> >> make[4]: "/home/sbruno/bsd/fbsd_head/sys/modules/if_gif/Makefile" line
>> >> 12: warning: Couldn't read shell's output for
>> >> "cat /home/sbruno/bsd/obj/mips/mips.mips/home/sbruno/bsd/fbsd_head/sys/WZR-300HP/opt_inet6.h"
>> >>
>> >>
>> >> Shouldn't this cat be done in a saner way?
>> >>
>> >
>> > This is done quite often throughout the tree, and bmake(1) does not like
>> > it when there is no value assigned from the '!=' expansion.
>> >
>> > The fix I've seen most commonly done is to echo a newline after the
>> > assignment, such as:
>> >
>> > Index: sys/modules/if_gif/Makefile
>> > ===================================================================
>> > --- sys/modules/if_gif/Makefile (revision 271215)
>> > +++ sys/modules/if_gif/Makefile (working copy)
>> > @@ -9,7 +9,7 @@ KMOD= if_gif
>> > SRCS= if_gif.c in_gif.c opt_inet.h opt_inet6.h opt_mrouting.h
>> >
>> > .if defined(KERNBUILDDIR)
>> > -OPT_INET6!= cat ${KERNBUILDDIR}/opt_inet6.h
>> > +OPT_INET6!= cat ${KERNBUILDDIR}/opt_inet6.h; echo
>> > .if empty(OPT_INET6)
>> > MK_INET6_SUPPORT=no
>> > .endif
>>
>> Shouldn’t this all be removed and replaced with equivalent logic provided by kern.opts.mk?
>
> Probably.
>
> Glen
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmom0Zq088TaobNNPzd0GP4zm%2B330kjCNm-vbvt=TOoD%2B3A>