Date: Tue, 7 Oct 2014 18:23:14 +0000 From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: arch@FreeBSD.org Subject: =?windows-1252?Q?PMC_=93unhalted-core-cycles=94_counted_=27Branc?= =?windows-1252?Q?h_Instruction_Retired=27___=5Bwas=3A_Fwd=3A_svn?= =?windows-1252?Q?_commit=3A_r272713_-_head/sys/dev/hwpmc=5D?= Message-ID: <79B730FB-26F4-4E74-BB68-D8E681278A4F@FreeBSD.org> References: <201410071800.s97I0ZV7023909@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, in case you have used =93unhalted-core-cycles=94 for any PMC = measurements in the last 17 months in HEAD or stable/10 (possibly more = branches), you might want to go and re-visit your results. In the interest of my research I=92d appreciate if you could also drop = me a private email (Reply-To set, don=92t reply to all for this unless = you want to) if this might have affected any of your work. Best Regards, Bjoern Begin forwarded message: > From: "Bjoern A. Zeeb" <bz@FreeBSD.org> > Subject: svn commit: r272713 - head/sys/dev/hwpmc > Date: 7 Oct 2014 18:00:35 GMT > To: src-committers@freebsd.org, svn-src-all@freebsd.org, = svn-src-head@freebsd.org >=20 > Author: bz > Date: Tue Oct 7 18:00:34 2014 > New Revision: 272713 > URL: https://svnweb.freebsd.org/changeset/base/272713 >=20 > Log: > Since introducing the extra mapping in r250103 for architectural = performance > events we have actually counted 'Branch Instruction Retired' when = people > asked for 'Unhalted core cycles' using the 'unhalted-core-cycles' = event mask > mnemonic. >=20 > Reviewed by: jimharris > Discussed with: gnn, rwatson > MFC after: 3 days > Sponsored by: DARPA/AFRL >=20 > Modified: > head/sys/dev/hwpmc/hwpmc_core.c >=20 > Modified: head/sys/dev/hwpmc/hwpmc_core.c > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/sys/dev/hwpmc/hwpmc_core.c Tue Oct 7 17:39:30 2014 = (r272712) > +++ head/sys/dev/hwpmc/hwpmc_core.c Tue Oct 7 18:00:34 2014 = (r272713) > @@ -1796,7 +1796,7 @@ iap_is_event_architectural(enum pmc_even > switch (pe) { > case PMC_EV_IAP_ARCH_UNH_COR_CYC: > ae =3D CORE_AE_UNHALTED_CORE_CYCLES; > - *map =3D PMC_EV_IAP_EVENT_C4H_00H; > + *map =3D PMC_EV_IAP_EVENT_3CH_00H; > break; > case PMC_EV_IAP_ARCH_INS_RET: > ae =3D CORE_AE_INSTRUCTION_RETIRED; >=20 =97=20 Bjoern A. Zeeb "Come on. Learn, goddamn it.", WarGames, 1983
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?79B730FB-26F4-4E74-BB68-D8E681278A4F>