Date: Mon, 22 Jun 2015 09:51:23 +0800 From: Kevin Lo <kevlo@FreeBSD.org> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: current@FreeBSD.org, adrian@FreeBSD.org Subject: Re: converted urtw(4) Was: [Testers needed!] WiFi drivers changes Message-ID: <20150622015123.GA56922@ns.kevlo.org> In-Reply-To: <20150618104030.GK73119@glebius.int.ru> References: <20150616163436.GP73119@glebius.int.ru> <20150617082855.GT73119@glebius.int.ru> <20150618081655.GA44125@ns.kevlo.org> <20150618104030.GK73119@glebius.int.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jun 18, 2015 at 01:40:30PM +0300, Gleb Smirnoff wrote: > > On Thu, Jun 18, 2015 at 04:16:55PM +0800, Kevin Lo wrote: > K> > you signed up as tester of urtw(4). I have converted urtw(4) > K> > and uploaded new patch at: > K> > > K> > https://reviews.freebsd.org/D2655 > K> > > K> > Please try, report and update the project page. > K> > > K> > https://wiki.freebsd.org/projects/ifnet/net80211 > K> > > K> > Thanks a lot for your help with the project. > K> > K> After bringing interface up I'm getting: > K> http://i.imgur.com/XhOVJ68.jpg > > I've found the problem and updated the diff. Please test once more. > > Thanks for help! Without you the bug could leak into subversion. Thank you Gleb. urtw(4) works fine on amd64. # dmesg |grep urtw urtw0: <vendor 0x0bda product 0x8187, class 0/0, rev 2.00/1.00, addr 2> on usbus4 urtw0: unknown RTL8187L type: 0x8000000 urtw0: rtl8187l rf rtl8225u hwrev none One minor problem, I got an compiler error and this diff below fixes it. --- D2655.diff.orig 2015-06-22 09:45:48.836385086 +0800 +++ D2655.diff 2015-06-22 09:47:56.121431950 +0800 @@ -10421,14 +10421,6 @@ struct urtw_vap *uvp = URTW_VAP(vap); struct ieee80211_node *ni; usb_error_t error = 0; -@@ -1905,7 +1858,6 @@ - default: - break; - } --fail: - URTW_UNLOCK(sc); - IEEE80211_LOCK(ic); - return (uvp->newstate(vap, nstate, arg)); @@ -1915,12 +1867,11 @@ urtw_watchdog(void *arg) { > > -- > Totus tuus, Glebius. Kevin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150622015123.GA56922>