Date: Sun, 9 Aug 2015 13:30:50 +0200 From: Kurt Jaeger <lists@opsec.eu> To: Anders Jensen-Waud <anders@jensenwaud.com>, freebsd-ports@freebsd.org Subject: Re: lang/mono: Update to 4.0.3.19 Message-ID: <20150809113050.GH40589@home.opsec.eu> In-Reply-To: <20150809112030.GG40589@home.opsec.eu> References: <55C7196A.8000600@jensenwaud.com> <20150809112030.GG40589@home.opsec.eu>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi! > Ok, got that. As Romain is the maintainer of the port, he needs > to approve PR 201883 Technically, after 14 days oe non-action on a PR, the maintainer is seen as timed-out for that PR and anyone can commit. This is almost the case with that PR. There are other issues to consider: 1) If the port to be updated is a dependency for other ports, the submitter should probably test if the dependent ports still build and run with that change and say so in the PR, eg. "I tested the build of the dependent ports and if they work, see list attached". Otherwise the committer has to find the dependent ports, and this takes time. I used grep -Rl '{PORTSDIR}/lang/mono' * > /tmp/mono on my /usr/ports/ and did not find any port that depends on mono. This is surprising 8-} 2) If it's an update, provide a changelog entry in the PR. What happened between the old and the suggested version ? Otherwise the committer has to find a changelog and this takes time. -- pi@opsec.eu +49 171 3101372 5 years to go !
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150809113050.GH40589>