Date: Sun, 17 Jan 2016 10:30:07 +0200 From: Konstantin Belousov <kib@kib.kiev.ua> To: Mateusz Guzik <mjguzik@gmail.com> Cc: Vijay Singh <vijju.singh@gmail.com>, freebsd-hackers@freebsd.org, Chagin Dmitry <dchagin@freebsd.org> Subject: Re: irrelevant locking Message-ID: <20160117083007.GQ3942@kib.kiev.ua> In-Reply-To: <20160117082439.GB1963@dft-labs.eu> References: <20160116195819.GA41610@chd.heemeyer.club> <20160116202643.GL3942@kib.kiev.ua> <CALCNsJT_gH5gJaB%2ByVQRcON84JntSUevG8-X-0Z5_13DkPC%2BBg@mail.gmail.com> <20160116224312.GA1963@dft-labs.eu> <20160117034315.GN3942@kib.kiev.ua> <20160117082439.GB1963@dft-labs.eu>
next in thread | previous in thread | raw e-mail | index | archive | help
--k4f25fnPtRuIRUb3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Jan 17, 2016 at 09:24:40AM +0100, Mateusz Guzik wrote: > As a side note I think current code is buggy. VOP_CLOSE is being called > with only shared lock held even for filesystems without > MNTK_EXTENDED_SHARED, I don't know how harmful this really is. Generally LK_EXCLUSIVE for VOP_CLOSE() is only needed when closing for write. Look at the vn_close() selection of the lock mode as an example. --k4f25fnPtRuIRUb3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWm1EPAAoJEJDCuSvBvK1BYkUP/j6L/TyCEasep58e8rQfJGv/ KRnh+coSW2aui+udASebtY/DvemBG8v2M2YdYb4X/L0ejqCh1zvgrz9XKqvUp4H6 rGVE3GKNKfB2tWdFl3D0PhbAirZkaoPYdj/Jhy8rDh6MKKicNRAzaDYmej2FvpqZ ft95/ht8FCZORNUiFsyL2XnHYV4baBbQrqd0L18tTizNG/TQ3qXJziu+0YZbt/V3 krbxeHwWoeyzHeqtRYRNFeIER1WBU1guVxDHIVt3qoYe4DR6ZEEMIAk0PyPR6fEE V3QoA6sgM2G65azKqnJrn66hSz/ZF2hcTWIxOOwRveLghx5VjIMSVUhab+9soY02 YC6jNXUlQksMGgtD99pZXF3s4kPsZcPTc3SrPdCLfr+de0xIu8q73eUC3pRUvIWD BNiBqpvDbS8Pv7D/WN+YBfswLAC21aOQtP2pb8A798gpB7Q5lL2ovTmza9tarm+Y nUy5mQqu2LHASjcFSbMh/3Wtr3hD0mEKKgjMUlWNre9GTeZZF3TEglMcEi7hXjRf VQ4gEM5U85+1A5dKHZU72rH6Wjro2GiFmHgdrXxT5QyVBEGB2c231U/zbPiBcg0U z1etSYvzzkr+AEVc+pdeYBEBFs9QsklTr0N+Hhv2EVeopmDfTFhncHbZisUl79Xe nqoK56zvD3gnHqZ+63Nv =cdFW -----END PGP SIGNATURE----- --k4f25fnPtRuIRUb3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160117083007.GQ3942>