Date: Sun, 24 Apr 2016 05:24:43 +0200 From: Kurt Jaeger <lists@opsec.eu> To: Bob Eager <rde@tavi.co.uk> Cc: ports@freebsd.org Subject: Re: Best way to submit a port upgrade Message-ID: <20160424032443.GU2282@home.opsec.eu> In-Reply-To: <20160424005620.43a31661@raksha.tavi.co.uk> References: <20160424005620.43a31661@raksha.tavi.co.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi! > Background: I have created various ports, but I have never upgraded one > to a new version (i.e. from a new distfile) before. > > I now have an upgrade to a new version of the port. I have: > > - Updated Makefile > - Updated pkg-plist > - Updated distinfo > - New files in files/ > - New patches in files/ > > I am slightly unsure how to submit this. The options seem to be: > > a) A recursive diff (I know about 'port diff'). > b) An svn diff Both are fine. > However, what about comments on each of my changes? Should there be > annotation on what I have done, and how do I specify that in the PR? There are two change types: - those that you did to the port itself Only if your changes to the port are fancy, it's necessary to explain about them. - those that upstream did to the new version If you update from a.b to x.y and the upstream has a changelog, please provide a link to that changelog. If there's no linkable changelog, please provide a short block of text that explains the changes from upstream. If you put those changes in a comment field in the PR, that's very nice! -- pi@opsec.eu +49 171 3101372 4 years to go !
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160424032443.GU2282>