Date: Wed, 1 Jun 2016 01:53:52 -0700 From: Mark Millard <markmi@dsl-only.net> To: Navdeep Parhar <nparhar@gmail.com> Cc: FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: 11.0 -r300944 build*KERNEL* via amd64-gcc fails for: .../dev/cxgb/ulp/tom/cxgb_listen.c:926:13: error: redundant redeclaration of 'tcp_dooptions'; cxgbe has an issue too Message-ID: <0090BCEC-2937-42EC-B875-A06018BEB55D@dsl-only.net> In-Reply-To: <20160601073612.GB4400@ox> References: <1885ED2D-29CB-47EF-B746-7CAD52E91605@dsl-only.net> <AE72AC5F-7696-4C69-AD5A-2A99563CE75A@dsl-only.net> <086B90E6-2E0C-4AA9-B429-523685EF1459@dsl-only.net> <20160601073612.GB4400@ox>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2016-Jun-1, at 12:36 AM, Navdeep Parhar <nparhar at gmail.com> wrote: > On Tue, May 31, 2016 at 10:49:29PM -0700, Mark Millard wrote: >> On 2016-May-31, at 10:31 PM, Mark Millard <markmi at dsl-only.net> = wrote: >>=20 > <snip> >>=20 >> If the offending declaration in cxgb_listen.c is commented out (or = removed) >> there is a "next problem" but for cxgbe: >>=20 >>> --- all_subdir_cxgbe/tom --- >>> /usr/src/sys/modules/cxgbe/tom/../../../dev/cxgbe/tom/t4_listen.c: = In function 'do_pass_accept_req': >>> = /usr/src/sys/modules/cxgbe/tom/../../../dev/cxgbe/tom/t4_listen.c:640:1: = warning: inlining failed in call to 'release_synqe': call is unlikely = and code size would grow [-Winline] >=20 > Can you try removing the "inline" at line 639 in t4_listen.c and see = if that > makes a difference? >=20 > Regards, > Navdeep I tried commenting out the inline. Looks like cxgbe code has the same sort of redundant declaration problem = as cxgb code: > --- t4_listen.o --- > = /usr/src/sys/modules/cxgbe/tom/../../../dev/cxgbe/tom/t4_listen.c:669:13: = error: redundant redeclaration of 'tcp_dooptions' = [-Werror=3Dredundant-decls] > extern void tcp_dooptions(struct tcpopt *, u_char *, int, int); > ^ > In file included from = /usr/src/sys/modules/cxgbe/tom/../../../dev/cxgbe/tom/t4_listen.c:61:0: > /usr/src/sys/netinet/tcp_var.h:769:7: note: previous declaration of = 'tcp_dooptions' was here > void tcp_dooptions(struct tcpopt *, u_char *, int, int); > ^ . . . > --- t4_listen.o --- > cc1: all warnings being treated as errors > *** [t4_listen.o] Error code 1 Commenting that out as well lead to a failure in a very different area = of code: > --- all_subdir_drm2/i915kms --- > In file included from = /usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/intel_drv.h:31:0,= > from = /usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/dvo.h:35, > from = /usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/dvo_ch7xxx.c:32: > /usr/src/sys/dev/drm2/i915/i915_drv.h:1621:6: error: redundant = redeclaration of 'i915_gem_dump_object' [-Werror=3Dredundant-decls] > void i915_gem_dump_object(struct drm_i915_gem_object *obj, int len, > ^ > /usr/src/sys/dev/drm2/i915/i915_drv.h:1612:6: note: previous = declaration of 'i915_gem_dump_object' was here > void i915_gem_dump_object(struct drm_i915_gem_object *obj, int len, > ^ > In file included from = /usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/dvo.h:35:0, > from = /usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/dvo_ch7xxx.c:32: > = /usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/intel_drv.h:671:1= 3: error: redundant redeclaration of 'intel_fbc_enabled' = [-Werror=3Dredundant-decls] > extern bool intel_fbc_enabled(struct drm_device *dev); > ^ > In file included from = /usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/intel_drv.h:31:0,= > from = /usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/dvo.h:35, > from = /usr/src/sys/modules/drm2/i915kms/../../../dev/drm2/i915/dvo_ch7xxx.c:32: > /usr/src/sys/dev/drm2/i915/i915_drv.h:1676:13: note: previous = declaration of 'intel_fbc_enabled' was here > extern bool intel_fbc_enabled(struct drm_device *dev); > ^ . . . > --- all_subdir_drm2 --- > cc1: all warnings being treated as errors > *** [dvo_ch7xxx.o] Error code 1 =3D=3D=3D Mark Millard markmi at dsl-only.net
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0090BCEC-2937-42EC-B875-A06018BEB55D>