Date: Fri, 9 Sep 2016 09:51:15 +1000
From: Aristedes Maniatis <amaniatis@apache.org>
To: Mark Linimon <linimon@lonesome.com>, Aristedes Maniatis <amaniatis@apache.org>
Cc: Mathieu Arnold <mat@FreeBSD.org>, FreeBSD Mailing List <freebsd-ports@freebsd.org>
Subject: Re: ${INSTALL_DATA} problems
Message-ID: <dd9c005e-d71d-19f3-c66c-db341b1c9a35@apache.org>
In-Reply-To: <20160908231339.GC15471@lonesome.com>
References: <cb59dad8-c6a0-ffc1-4705-9e8a66ca2679@apache.org> <cef2af10-89ce-e443-8bde-a7eb73d7a5bf@FreeBSD.org> <3f536359-c17a-d226-7ddc-7264b5af7c97@apache.org> <20160908231339.GC15471@lonesome.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9/09/2016 9:13am, Mark Linimon wrote:
> On Fri, Sep 09, 2016 at 08:29:12AM +1000, Aristedes Maniatis wrote:
>> Maybe the Makefile language will become clearer to me one day, but
>> I've been using FreeBSD since 4.0 and it hasn't clicked yet.
>
> Don't worry, the FreeBSD ports framework does things with the Makefile
> language that was never intended by make's designers :-)
>
> We do try to document things in the Porter's Handbook, but sometimes
> the only thing to do is wade into bsd.port.mk and friends and read the
> code. (Not recomended for the faint of heart, though.)
I think the most useful thing that could be done is more examples. Even a list of ports which implement things in the recommended ways and do the full range of common things.
/var/poudriere/ports/default # grep -R {CP} * | wc -l
1504
So me copying how mariadb101 does it (for example), gives me the wrong result. If I had a dozen "best practices" Makefiles I could copy them.
The second most useful thing would be to enhance portlint. Right now it feels like 95% of what it does is enforce some arbitrary ordering of keywords. But if it instead gave you hints "I see you are using {INSTALL_DATA} with a wildcard or directory, instead you should use {COPYTREE_SHARE}" then much time would be saved.
Cheers
Ari
--
-------------------------->
Aristedes Maniatis
GPG fingerprint CBFB 84B4 738D 4E87 5E5C 5EFA EF6A 7D2E 3E49 102A
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?dd9c005e-d71d-19f3-c66c-db341b1c9a35>