Date: Mon, 12 Dec 2016 10:11:23 +0200 From: clutton <clutton@zoho.com> To: freebsd-chromium@freebsd.org Cc: cpm <cpm@FreeBSD.org> Subject: Re: [package - head-amd64-default][www/chromium] Failed for chromium-54.0.2840.100_1 in build Message-ID: <1481530283.1473.8.camel@zoho.com> In-Reply-To: <201612102203.uBAM3Sok017799@slippy.cwsent.com> References: <201612102203.uBAM3Sok017799@slippy.cwsent.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Sat, 2016-12-10 at 14:03 -0800, Cy Schubert wrote:
> The hackish patch to address this and a subsequent break is:
>
> Index: /usr/ports/www/chromium/Makefile
> ===================================================================
> --- /usr/ports/www/chromium/Makefile (revision 428271)
> +++ /usr/ports/www/chromium/Makefile (working copy)
> @@ -16,6 +16,10 @@
>
> BROKEN_FreeBSD_9=does not configure
>
> +CC= /usr/local/bin/clang38
> +CXX= /usr/local/bin/clang++38
> +CPP= /usr/local/bin/clang-cpp38
> +
> BUILD_DEPENDS= ${LOCALBASE}/bin/gperf:devel/gperf \
> bash:shells/bash \
> python:lang/python \
> Index: /usr/ports/www/chromium/files/patch-services_ui_ws_BUILD.gn
> ===================================================================
> --- /usr/ports/www/chromium/files/patch-
> services_ui_ws_BUILD.gn (revision
> 428271)
> +++ /usr/ports/www/chromium/files/patch-services_ui_ws_BUILD.gn
> (nonexistent)
> @@ -1,14 +0,0 @@
> ---- services/ui/ws/BUILD.gn.orig 2016-10-06 04:02:24.000000000
> +0300
> -+++ services/ui/ws/BUILD.gn 2016-10-19 11:13:25.102806000 +0300
> -@@ -103,6 +103,11 @@
> - "window_tree_host_factory.h",
> - ]
> -
> -+ # Work around base r261801
> -+ if (is_bsd) {
> -+ defines = ["_LIBCPP_TRIVIAL_PAIR_COPY_CTOR=1"]
> -+ }
> -+
> - deps = [
> - # TODO(sad): Temporary, until the GPU process is split out of
> ws.
> - "//services/ui/gpu",
I hardcoded CC, CXX. This was done intentionally, chromium build system
assume that you don't take things from environment. May be better way
to do something with REPLACE_CMD in Makefile...??? Feel free to hack.
Also with recent CURRENT updates, we don't need that define, although
we need it for other supported bsd's < CURRENT. Can you look how we
applied the patch for < FreeBSD 10 and do this one in similar manner?
May be using devel/libc++ for everything < CURRENT and removing this
patch for all BSD's?
Then and only then, post merge request to github, or create a bug in
usual way.
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
iQIzBAABCAAdFiEEJS/zE0mE1p2+tYanfbA/jbLI/pAFAlhOW6wACgkQfbA/jbLI
/pCv9BAAmDExKWGom7+gjnZpkDoTCxOxBToCGfFsKxz8lqXy6M7KlWOfMHfKr+lH
nWjLuu9DrS3Or0ZYsTfz81brVfpYyQSSQLg29u/0arPvmC/zMSQ6svV9h4afUhZv
wZjcu1u+9m0ZUCmQM6rZO/7lrdVgbkgreW8FdbWusiNX4u7NkbaeWkvvydFKnFBN
wRAiVJraQlebD3d+Io+hwI5KrU8il6LXq78+uSRKfF7ZRJq6Jj9QBtssmjD+vlFm
oUKBrqsIz/lHKAop/wPguGgbdZC4v/z+/zX2Ae7hgx5bQpTiej55QivW414yydha
ZxL5dWHkEI28BOEah/+wYjvSER+RpW0FXPaS1r2/qW+sWNUBHo2j7b5ig6KcRvhR
WqoxmujalT6koo230XONzQHHirMCeHVn6jphARjvI0oqL0yvalhP3KYoVlUMm7bM
TcZNghXYltedg59MSwJg2OmlSzzLOcfhn/NXsGLyLJLpOXteoqYfX+r9SaE4RPB4
1TzBg4o0d4aU5112n0mhwI49Ca6vBFHewym3ZUIF2b858SA/GAe4gTBddfA20LUk
5ciNbAP0iXnbREFDGaqarFxBFVtmRADwsgRqU65QWuPvqRZbilk8R8WdO64lfW1k
vvuKRbyX8YRHq146MfGKm7M76IhKObuyePjESvCLGK/OBVklRV4=
=Lnsd
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1481530283.1473.8.camel>