Date: Fri, 24 Feb 2017 21:32:10 +0800 From: Jia-Shiun Li <jiashiun@gmail.com> To: Konstantin Belousov <kostikbel@gmail.com> Cc: John Baldwin <jhb@freebsd.org>, freebsd-current <freebsd-current@freebsd.org>, Konstantin Belousov <kib@freebsd.org> Subject: Re: TSC as timecounter makes system lag Message-ID: <CAHNYxxNiCP08dQ6bTJzHuAUmqwQUQJn%2B%2BCKMsCLiHQy2PxjP5A@mail.gmail.com> In-Reply-To: <20170224114541.GU2092@kib.kiev.ua> References: <20170113120534.GC2349@kib.kiev.ua> <20170223100829.GR2092@kib.kiev.ua> <CAHNYxxPDQtu5oJw2FEibYPaxZb==8CiSYyX6i2CXoi5DDB7PEw@mail.gmail.com> <2204246.QKzIRnxiUQ@ralph.baldwin.cx> <CAHNYxxNB2QT4_h6RtMz9-sAc5br_VBWj6-NafSXuf88W56BmBQ@mail.gmail.com> <20170224114541.GU2092@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Feb 24, 2017 at 7:45 PM, Konstantin Belousov <kostikbel@gmail.com> wrote: > On Fri, Feb 24, 2017 at 12:15:26PM +0800, Jia-Shiun Li wrote: > > Tested working on E7400 against r313909. And changing timecounter from/to > > TSC > > correctly enables/disables C2. > > > > The latter part cpu_disable_c2_sleep++ is not needed. When > > init_TSC_tc() got called timecounter is not yet tsc_timecounter. > > inittimecounter() later will do the work calling tc_windup(). > > > > You mean, just this > - if (cpu_deepest_sleep >= 2 && cpu_vendor_id == CPU_VENDOR_INTEL && > + if (cpu_vendor_id == CPU_VENDOR_INTEL && > is enough to fix the issue ? If yes, we can remove the cpu_deepest_sleep > variable. This is John' observation, I think he would prefer to prepare > the patch. > Correct. That's enough. -Jia-Shiun.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAHNYxxNiCP08dQ6bTJzHuAUmqwQUQJn%2B%2BCKMsCLiHQy2PxjP5A>