Date: Wed, 07 Jun 2017 14:12:44 -0500 From: Josh Paetzel <jpaetzel@FreeBSD.org> To: freebsd-current@freebsd.org Subject: Re: mount_smbfs gives error when stored crypted pw is used Message-ID: <1496862764.923234.1002086344.272B2D5D@webmail.messagingengine.com> In-Reply-To: <20170607192915.28088b71@thor.intern.walstatt.dynvpn.de> References: <20170606100034.GA4245@c720-r314251> <20170606123738.GA5213@c720-r314251> <20170607123531.GA4867@c720-r314251> <20170607172234.GA3972@c720-r314251> <20170607192915.28088b71@thor.intern.walstatt.dynvpn.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jun 7, 2017, at 12:29 PM, O. Hartmann wrote: > Am Wed, 7 Jun 2017 19:22:34 +0200 > Matthias Apitz <guru@unixarea.de> schrieb: >=20 > > El d=C3=ADa mi=C3=A9rcoles, junio 07, 2017 a las 02:35:31p. m. +0200, M= atthias Apitz escribi=C3=B3: > >=20 > > > I have located the bug in /usr/src/contrib/smbfs/lib/smb/subr.c=20 > > >=20 > > > The printf(3C) calls have been added for debugging; the bug is the > > > addition of 13 after crypting every char which let the mask used in ^= operation > > > exceeding 256, i.e. more than one byte, if the string to be crypted i= s long > > > enough. The two lines added: > > >=20 > > > if (pos > 256) > > > pos =3D pos-256; > > >=20 > > > fixes this issue and the crypting/decypting works fine; see below; > > >=20 > > > I'll later file a PR and propose the patch;=20=20 > >=20 > > The PR was already made in 2009: > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D132302 has a patch = attached (nearly > > the same solution as I have found), but was never ci'ed :-( > >=20 > > matthias > >=20 > >=20 >=20 > Wow ... that is, simply ... not very good! :-( >=20 > High quality! >=20 > --=20 > O. Hartmann >=20 > Ich widerspreche der Nutzung oder =C3=9Cbermittlung meiner Daten f=C3=BCr > Werbezwecke oder f=C3=BCr die Markt- oder Meinungsforschung (=C2=A7 28 Ab= s. 4 > BDSG). > Email had 1 attachment: > + Attachment2 > 1k (application/pgp-signature) I've taken the bug and am testing it now. Should have it committed by this evening. With some luck we can get it in to 11.1 --=20 Thanks, Josh Paetzel
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1496862764.923234.1002086344.272B2D5D>