Date: Tue, 28 Aug 2018 11:05:43 +0200 From: Yamagi Burmeister <lists@yamagi.org> To: lev@FreeBSD.org Cc: freebsd-fs@freebsd.org, MacCrest@gmail.com Subject: Re: ZFS (ARC) performance regression in r321610 Message-ID: <20180828110543.7cc7fa65a0e04e29a06a32b1@yamagi.org> In-Reply-To: <20180828105048.d5a4133c8a932eff900bd758@yamagi.org> References: <20180827154727.80f92fff9bbc931b37928d43@yamagi.org> <3c6f8c96-6ac9-7257-c8c0-8be2063a7c19@FreeBSD.org> <20180827182723.cd8ec6bac6448793b25ef91c@yamagi.org> <20180828105048.d5a4133c8a932eff900bd758@yamagi.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Signature=_Tue__28_Aug_2018_11_05_43_+0200_Cvc2V3Yc1zsmbKcz
Content-Type: text/plain; charset=US-ASCII
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Tue, 28 Aug 2018 10:50:48 +0200
Yamagi Burmeister <lists@yamagi.org> wrote:
> ZFS on Linux exposes zfs_abd_scatter_enabled through a module
> parameter. What about turning it into a sysctl? Something like this:
Ups, there sneaked an unrelated edit into the patch. New version here:
diff --git a/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/abd.c b/sys/cdd=
l/contrib/opensolaris/uts/common/fs/zfs/abd.c
index 2cd87c2b87b..5de74ef3325 100644
--- a/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/abd.c
+++ b/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/abd.c
@@ -140,6 +140,13 @@ static abd_stats_t abd_stats =3D {
*/
boolean_t zfs_abd_scatter_enabled =3D B_TRUE;
=20
+#if defined(__FreeBSD__) && defined(_KERNEL)
+SYSCTL_DECL(_vfs_zfs);
+
+SYSCTL_UINT(_vfs_zfs, OID_AUTO, abd_scatter_enabled, CTLFLAG_RWTUN,
+ &zfs_abd_scatter_enabled, 1, "Make all future ABDs linear");
+#endif
+
/*
* The size of the chunks ABD allocates. Because the sizes allocated from =
the
* kmem_cache can't change, this tunable can only be modified at boot. Cha=
nging
@@ -151,8 +158,6 @@ boolean_t zfs_abd_scatter_enabled =3D B_TRUE;
size_t zfs_abd_chunk_size =3D 4096;
=20
#if defined(__FreeBSD__) && defined(_KERNEL)
-SYSCTL_DECL(_vfs_zfs);
-
SYSCTL_ULONG(_vfs_zfs, OID_AUTO, abd_chunk_size, CTLFLAG_RDTUN,
&zfs_abd_chunk_size, 0, "The size of the chunks ABD allocates");
#endif
--=20
Homepage: https://www.yamagi.org
Github: https://github.com/yamagi
GPG: 0x1D502515
--Signature=_Tue__28_Aug_2018_11_05_43_+0200_Cvc2V3Yc1zsmbKcz
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEOXu/lxyufwz0gC5x6xRy5x1QJRUFAluFEGgACgkQ6xRy5x1Q
JRWBng//bVpzxhS7YfS13mxk9pqy2uyNNAsd8yGbZLNTbwqm+n8lcAqn4iUtQhyS
iUjCaAaPPJT2y+cQ39o8wzxDVs45EqMGRpMOeM6oKhPlBfHdKCmwtUHyI35bKWcK
H7SuQ5FWhXYGxUydD4pBwlYYSEg5FblkiIHTG5X9EtuywVtNigTFfGGaEGnsjapo
gv4iRUEULa8p83hgmtUEKQJhQc1QjgIh4Uv4oihlrYA8JxsbxidA8hr+b7TM8vdw
eclTokjeil8xejy1khh7Hg48l1m3ifxERKTK5xXDgnip73FI3AkGJu59U8mIh9vH
qqxkp1p42OT6F1L5TdTvp9auYcw0AbjfqFS8aOek9wf0xc+nv73WO99b96le3YHw
0cce5JuscrKrwiqeniCCUuSbaXEMq2LJA5yLwGh5vkKDNq1GgZiK3EShNP2DYBly
g0j1AlXmzho5SyIpohfHRDq53nXVxZtH8zK1xX9hZkiI3s00grFZbNrou9EMxfl5
HIKfWJTP/NlU5bCQ9uLf+c6QIvfL0bRmfnb2ZG6znZJ3uxj7SHpBmdVlZ6xlNBhJ
dLHXLvk3op/g9JIiubJ5iZH40wokdfpAhpr65FBdysXV6rfLvMtgV6p2gvrgrdnm
U8sWo0cm6C+t7hVu6Tkb2lIt3c0rA9a+OGcb/+PvzNMwSxIkFJE=
=9icN
-----END PGP SIGNATURE-----
--Signature=_Tue__28_Aug_2018_11_05_43_+0200_Cvc2V3Yc1zsmbKcz--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180828110543.7cc7fa65a0e04e29a06a32b1>