Date: Sat, 22 Dec 2018 23:31:09 +0300 From: Yuri Pankov <yuripv@yuripv.net> To: Cy Schubert <Cy.Schubert@cschubert.com> Cc: Mark Peek <mp@freebsd.org>, Enji Cooper <yaneurabeya@gmail.com>, Warner Losh <imp@bsdimp.com>, =?UTF-8?Q?Dag-Erling_Sm=c3=b8rgrav?= <des@freebsd.org>, freebsd-current <current@freebsd.org> Subject: Re: workaround for VMware WS NAT bug triggered by OpenSSH 7.8p1 changes Message-ID: <0503b382-d886-39a4-d265-b43d8adc15c9@yuripv.net> In-Reply-To: <201812222027.wBMKRGWJ050853@slippy.cwsent.com> References: <201812222027.wBMKRGWJ050853@slippy.cwsent.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --e7sW91Qf9WxzTaujtGEdAimN5k2EtpJ6Q Content-Type: multipart/mixed; boundary="3a9zlXDI7Z2P48EdQkgwMdVOMQOEfR5Wm"; protected-headers="v1" From: Yuri Pankov <yuripv@yuripv.net> To: Cy Schubert <Cy.Schubert@cschubert.com> Cc: Mark Peek <mp@freebsd.org>, Enji Cooper <yaneurabeya@gmail.com>, Warner Losh <imp@bsdimp.com>, =?UTF-8?Q?Dag-Erling_Sm=c3=b8rgrav?= <des@freebsd.org>, freebsd-current <current@freebsd.org> Message-ID: <0503b382-d886-39a4-d265-b43d8adc15c9@yuripv.net> Subject: Re: workaround for VMware WS NAT bug triggered by OpenSSH 7.8p1 changes References: <201812222027.wBMKRGWJ050853@slippy.cwsent.com> In-Reply-To: <201812222027.wBMKRGWJ050853@slippy.cwsent.com> --3a9zlXDI7Z2P48EdQkgwMdVOMQOEfR5Wm Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Cy Schubert wrote: > In message <e84b7b4a-89ab-2ad9-ac3a-e08b8491e5cc@yuripv.net>, Yuri=20 > Pankov write > s: >> This is an OpenPGP/MIME signed message (RFC 4880 and 3156) >> --NAG3HGfiwhsHyGq3aNdsIv1NzTEMODbUH >> Content-Type: multipart/mixed; boundary=3D"c7yUHUJpZYpJqOrOWLAb4sE3Rmh= 2alrdi"; >> protected-headers=3D"v1" >> From: Yuri Pankov <yuripv@yuripv.net> >> To: Cy Schubert <Cy.Schubert@cschubert.com> >> Cc: Mark Peek <mp@freebsd.org>, Enji Cooper <yaneurabeya@gmail.com>, >> Warner Losh <imp@bsdimp.com>, =3D?UTF-8?Q?Dag-Erling_Sm=3Dc3=3Db8rgra= v?=3D >> <des@freebsd.org>, freebsd-current <current@freebsd.org> >> Message-ID: <e84b7b4a-89ab-2ad9-ac3a-e08b8491e5cc@yuripv.net> >> Subject: Re: workaround for VMware WS NAT bug triggered by OpenSSH 7.8= p1 >> changes >> References: <201812222009.wBMK9H5T050103@slippy.cwsent.com> >> In-Reply-To: <201812222009.wBMK9H5T050103@slippy.cwsent.com> >> >> --c7yUHUJpZYpJqOrOWLAb4sE3Rmh2alrdi >> Content-Type: text/plain; charset=3Dutf-8 >> Content-Language: en-US >> Content-Transfer-Encoding: quoted-printable >> >> Cy Schubert wrote: >>> In message <913730b6-c6f0-60b8-a589-e89e872b7f42@yuripv.net>, Yuri=3D= 20 >>> Pankov write >>> s: >>>> Yuri Pankov <yuripv@yuripv.net> wrote: >>>>> In-Reply-To: <CAGGgMJf45vkNY6o6-in+kiAFHxsFZpKBc4Oa6qiCFnzKnRjk1g@m= ai=3D >> >>> l.gmail. >>>>> com> >>>>> Mark Peek wrote: >>>>>> On Fri, Dec 21, 2018 at 9:30 PM Enji Cooper <yaneurabeya@gmail.com= > >>> wro=3D3D >>>>> te: >>>>>> =3D3D20 >>>>>>> >>>>>>>> On Dec 21, 2018, at 17:48, Yuri Pankov <yuripv@yuripv.net> wrote= : >>>>>>>> >>>>>>>> Mark Peek wrote: >>>>>>>>> Thanks for the cc:. I forwarded the original report on to an=3D= 20 >>> interna=3D3D >>>>> l >>>>>>>>> VMware desktop product contact. >>>>>>>> >>>>>>>> Thank you. >>>>>>>> >>>>>>>>> What version of Workstation or Fusion is this occurring on? I=3D= 20 >>> saw >>>>>>>>> Workstation 14 mentioned but curious if it occurs on=3D20 >>> Workstation 15 >>>>>>>>> (latest). >>>>>>>> >>>>>>>> Running the latest available for download: 15.0.2 build-10952284= =2E >>>>>>> >>>>>>> This is affecting me on VMware Fusion 11.0.1-11.0.2. I know it=3D= 20 >>> wasn=3D3DE2=3D3D >>>>> =3D3D80=3D3D99t >>>>>>> affecting me on 10.x. I didn=3D3DE2=3D3D80=3D3D99t install 11.0.0= , so I=3D20 >>> don=3D3DE2=3D3D80=3D3D99=3D3D >>>>> t know if it >>>>>>> affects that version... >>>>>>> >>>>>>> Thanks so much! >>>>>>> >>>>>>> -Enji >>>>>> =3D3D20 >>>>>> =3D3D20 >>>>>> BTW, there appears to be a workaround here using -o=3D20 >>> 'IPQoS=3D3D3Dthroughput=3D3D >>>>> ' >>>>>> (untested by me). I've seen the issue forwarded internally but no=3D= 20 >>> furth=3D3D >>>>> er >>>>>> discussions yet. >>>>>> =3D3D20 >>>>>> https://communities.vmware.com/thread/590825 >>>> >>>> Yes, that's exactly what the patch attached to original message does= i=3D >> f >>>> we are running as a VMware guest. The workaround is known and it wo= rk=3D >> s, >>>> but it's not immediately clear and I just wanted it to be the defaul= t >>>> for the time being. >>> =3D20 >>> The patch assumes VMWARE_GUEST_WORKAROUND unconditionally. Is this=3D= 20 >>> intended? >> >> It's the added code that is ifdef'ed VMWARE_GUEST_WORKAROUND, so it ca= n >> be ripped out easily when no longer needed, and yes, it's enabled >> unconditionally for now. And the check itself is if 'kern.vm_guest' >> reports 'vmware'. >=20 > It doesn't look that conditional to me. Indeed, and that's what I said exactly :-) The added code is enabled unconditionally, and the added code also has a check for vmware guest. The ifdefs are there only to show that this is local addition, nothing el= se. I'm not saying it needs to be done this way, this is just something I did quickly after installing yet another VM and forgetting to modify my ~/.ssh/config to include the workaround. --3a9zlXDI7Z2P48EdQkgwMdVOMQOEfR5Wm-- --e7sW91Qf9WxzTaujtGEdAimN5k2EtpJ6Q Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE+Gq3PsPeLT4tL/9wk4vgf7Eq4WwFAlwenw0ACgkQk4vgf7Eq 4WyIegf6A9GzStMWvJJm8rBz16USfMCQcfaFy7d78R6GpJJ8C6RCBnhEctznx9og atxstLlr0ar0qKUHWRVSKUGtAGp8599MJHJWNUR8DcHZxOhfyempASUhZq0usGLe /uav9JDc2n4sPcLckHVI/No5UUSnV3sdYGHmrBniNStlwxv0raeeRMUd1p5SYt45 XG41OuEGfih+fiDR+ITsooxEvQCBF1emPoYB0eHw2hnlfNzeQrnCMyRAduB/uw6+ 9WrHI9dDaPeZiSOhUBjXOtdyahW4fd9hclfIEDs40YTbnTh3jOm/g07lSUf2SEDK zWujMO+S0IG4H7giriVd9wYvmn/+/A== =p+yW -----END PGP SIGNATURE----- --e7sW91Qf9WxzTaujtGEdAimN5k2EtpJ6Q--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0503b382-d886-39a4-d265-b43d8adc15c9>