Date: Fri, 28 Dec 2018 11:40:50 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Gary Jennejohn <gljennjohn@gmail.com> Cc: freebsd-current@freebsd.org Subject: Re: HEAD buildworld fails in libc Message-ID: <20181228094050.GG53138@kib.kiev.ua> In-Reply-To: <20181228101812.42000b6d@ernst.home> References: <20181228101812.42000b6d@ernst.home>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Dec 28, 2018 at 10:18:12AM +0100, Gary Jennejohn wrote:
> I don't know why this hasn't already been reported, but I've been
> seeing this error since the commit was made.
>
> ===> lib/libc (obj,all,install)
> /usr/src/lib/libc/string/strerror.c:96:11: error: passing 'const char []' to parameter of type 'char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
> __uprefix,
> ^~~~~~~~~
> /usr/src/lib/libc/string/strerror.c:61:23: note: passing argument to parameter 'uprefix' here
> errstr(int num, char *uprefix, char *buf, size_t len)
> ^
> 1 error generated.
> *** [strerror.o] Error code 1
>
> I deleted /usr/obj, disabled META_MODE and ran the ``make buildworld''
> with -j1.
>
> My /usr/src is at r342569.
Do you have WITHOUT_NLS set ? If yes, then the following should fix it.
Confirm and I will commit.
diff --git a/lib/libc/string/strerror.c b/lib/libc/string/strerror.c
index be3732d5b9e..7cd984ea48f 100644
--- a/lib/libc/string/strerror.c
+++ b/lib/libc/string/strerror.c
@@ -58,7 +58,7 @@ __FBSDID("$FreeBSD$");
* statically linked binaries.
*/
static void
-errstr(int num, char *uprefix, char *buf, size_t len)
+errstr(int num, const char *uprefix, char *buf, size_t len)
{
char *t;
unsigned int uerr;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181228094050.GG53138>