Date: Wed, 23 Sep 2020 17:56:15 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Alexander Leidinger <Alexander@leidinger.net> Cc: freebsd-hackers@freebsd.org Subject: Re: RFC: copy_file_range(3) Message-ID: <20200923145615.GH2570@kib.kiev.ua> In-Reply-To: <20200923122401.Horde.uXmEqpCzVbCyXTuyukZeRwU@webmail.leidinger.net> References: <CAOtMX2iFZZpoj%2Bap21rrju4hJoip6ZoyxEiCB8852NeH7DAN0Q@mail.gmail.com> <YTBPR01MB39666188FC89399B0D632FE8DD3D0@YTBPR01MB3966.CANPRD01.PROD.OUTLOOK.COM> <CAOtMX2gMYdcx0CUC1Mky3ETFr1JkBbYzn17i11axSW=HRTL7OA@mail.gmail.com> <YTBPR01MB3966C1D4D10BE836B37955F5DD3D0@YTBPR01MB3966.CANPRD01.PROD.OUTLOOK.COM> <CAOtMX2jHMRD0Hno03f2dqjJToR152u8d-_40GM_%2BBvNPkN_smA@mail.gmail.com> <YTBPR01MB3966BA18F43F7B6353171E67DD380@YTBPR01MB3966.CANPRD01.PROD.OUTLOOK.COM> <20200923122401.Horde.uXmEqpCzVbCyXTuyukZeRwU@webmail.leidinger.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Sep 23, 2020 at 12:24:01PM +0200, Alexander Leidinger via freebsd-hackers wrote: > Quoting Rick Macklem <rmacklem@uoguelph.ca> (from Wed, 23 Sep 2020 01:18:18 > +0000): > > > Well, I ran some quick benchmarks using the attached programs, plus "cp" both > > before and with your copy_file_range() patch. > > copya - Does what I think your plan is above, with a limit of 2Mbytes > > for "len". > > copyb -Just uses copy_file_range() with 128Mbytes for "len". > > > > I first created the sparse file with createsparse.c. It is admittedly a > > worst case, > > creating alternating holes and data blocks of the minimum size supported by > > the file system. (I ran it on a UFS file system created with defaults, > > so the minimum > > hole size is 32Kbytes.) > > Not related to the topic of changing cp, but related to the topic of > copy_file_range: does nullfs support (as in pass-through to the underlying > FS) copy_file_range? Nullfs bypasses VOP_COPY_FILE_RANGE() same as any other multi-vp arg VOP. What makes you think it is different ?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200923145615.GH2570>