Date: Thu, 11 Feb 2021 11:23:44 -0800 From: John Baldwin <jhb@FreeBSD.org> To: Daniel Ebdrup Jensen <debdrup@FreeBSD.org>, doc-committers@FreeBSD.org, dev-commits-doc-all@FreeBSD.org Subject: Re: git: 5476df45eb - main - 13.0R/relnotes: Add entries for changes that happened in bhyve. Message-ID: <4cf5028f-df8e-f910-b768-27ad49398da5@FreeBSD.org> In-Reply-To: <202102110419.11B4J64X034699@gitrepo.freebsd.org> References: <202102110419.11B4J64X034699@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2/10/21 8:19 PM, Daniel Ebdrup Jensen wrote: > The branch main has been updated by debdrup: > > URL: https://cgit.FreeBSD.org/doc/commit/?id=5476df45eb064fc3bdd7172ce9f38822eb143307 > > commit 5476df45eb064fc3bdd7172ce9f38822eb143307 > Author: Daniel Ebdrup Jensen <debdrup@FreeBSD.org> > AuthorDate: 2021-02-10 04:32:24 +0000 > Commit: Daniel Ebdrup Jensen <debdrup@FreeBSD.org> > CommitDate: 2021-02-11 04:18:46 +0000 > > 13.0R/relnotes: Add entries for changes that happened in bhyve. > > While here, implement a template for cgit links called 'commit' for lack > of a better term. > > This fixes the only build issue with this patch, and has been tested in > Firefox with the run target as well. Hmm, can you make 'commit' configurable so it doesn't hardcode the src repository? E.g. can it take an optional 2nd arg (which defaults to 'src') which is the repo? I think it would also be good if it was 'githash' or the like as that's a bit more future proof should we have to change to something else in the future. (The old XML shortcut for this was named githash for precisely that reason.) It might also be nice if we could provide the full hash and centralize the abbreviation logic in the keyword so that if we eventually have to expand the prefix as our history grows we can fix that in one place and rebuild the docs without having to go fix all the actual places that use the keyword. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4cf5028f-df8e-f910-b768-27ad49398da5>