Date: Fri, 26 Feb 2021 13:53:02 -0800 From: Enji Cooper <yaneurabeya@gmail.com> To: Alex Richardson <arichardson@FreeBSD.org> Cc: Kristof Provost <kp@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 3775ddcf5a12 - main - tests/sys/netgraph: Tell kyua that perl is required Message-ID: <53DA1EDF-3C9B-4573-AB30-EE3F581471AD@gmail.com> In-Reply-To: <202102231744.11NHi08p021198@gitrepo.freebsd.org> References: <202102231744.11NHi08p021198@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Feb 23, 2021, at 9:44 AM, Alex Richardson <arichardson@FreeBSD.org> = wrote: >=20 > The branch main has been updated by arichardson: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D3775ddcf5a12c8e23970e94b7b165bf2= 3c92aeba >=20 > commit 3775ddcf5a12c8e23970e94b7b165bf23c92aeba > Author: Alex Richardson <arichardson@FreeBSD.org> > AuthorDate: 2021-02-23 17:02:31 +0000 > Commit: Alex Richardson <arichardson@FreeBSD.org> > CommitDate: 2021-02-23 17:43:31 +0000 >=20 > tests/sys/netgraph: Tell kyua that perl is required >=20 > Otherwise these tests fail with incomprehensible error messages. >=20 > Reviewed By: kp > Differential Revision: https://reviews.freebsd.org/D28894 It might be a good idea to rely on ${TAP_PERL_INTERPRETER} = instead, in the code, however=E2=80=A6 is there a reason why the = one-liners are written in perl instead of awk? Cheers, -Enji
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53DA1EDF-3C9B-4573-AB30-EE3F581471AD>