Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 2 Mar 2021 20:41:32 +0200
From:      Toomas Soome <tsoome@me.com>
To:        "Rodney W. Grimes" <freebsd-rwg@gndrsh.dnsmgr.net>
Cc:        rgrimes@freebsd.org, Jakob Alvermark <jakob@alvermark.net>, FreeBSD Developers <developers@freebsd.org>, freebsd-current <freebsd-current@freebsd.org>
Subject:   Re: testers needed: loader: use display pixel density for font autoselection
Message-ID:  <FB23EA9A-5D3D-4C96-B639-8822B8542796@me.com>
In-Reply-To: <202103021832.122IW831047925@gndrsh.dnsmgr.net>
References:  <202103021832.122IW831047925@gndrsh.dnsmgr.net>

next in thread | previous in thread | raw e-mail | index | archive | help


> On 2. Mar 2021, at 20:32, Rodney W. Grimes =
<freebsd-rwg@gndrsh.dnsmgr.net> wrote:
>=20
>>> On 26. Feb 2021, at 17:56, Rodney W. Grimes =
<freebsd-rwg@gndrsh.dnsmgr.net> wrote:
>>>=20
>>>>> On 26. Feb 2021, at 05:42, Rodney W. Grimes =
<freebsd@gndrsh.dnsmgr.net> wrote:
>>>>>=20
>>>>>>> On 23. Feb 2021, at 17:53, Jakob Alvermark <jakob@alvermark.net> =
wrote:
>>>>>>>=20
>>>>>>> On 2/23/21 12:27 PM, Toomas Soome via freebsd-current wrote:
>>>>>>>> hi!
>>>>>>>>=20
>>>>>>>> I have done some work to make font pickup a bit smarter =
(hopefully better;), but my own ability to test is limited to one bugged =
supermicro and one MBP with retina display?
>>>>>>>>=20
>>>>>>>> The phab link ishttps://reviews.freebsd.org/D28849  =
<https://reviews.freebsd.org/D28849>;
>>>>>>>>=20
>>>>>>>> I have built loader binaries as well (bios and uefi):
>>>>>>>> loader_lua<http://148-52-235-80.sta.estpak.ee/loader_lua>;
>>>>>>>> =
loader_lua.efi<http://148-52-235-80.sta.estpak.ee/loader_lua.efi>;
>=20
> I have tested this on:
> 	Lenovo W530
> 	Dell E5470
> 	Acer Aspire 1410
>=20
> all work fine with resonable display resolution.
>=20
> One more comment below...
>=20
>>>>>>>>=20
>>>>>>>> To test, you should remove screen.font=3D line from loader.conf =
and test with different resolutions.
>>>>>>>>=20
>>>>>>>> thanks,
>>>>>>>> toomas
>>>>>>>=20
>>>>>>>=20
>>>>>>>=20
>>>>>>> Hi Toomas,
>>>>>>>=20
>>>>>>>=20
>>>>>>> I tested on five different setups.
>>>>>>>=20
>>>>>>> Surface Pro 10.6"@1920x1080:
>>>>>>>=20
>>>>>>> The loader menu looks different, the "FreeBSD" text is on the =
right side of the screen.
>>>>>>=20
>>>>>>=20
>>>>>> I think, this was the lua script bug we did fix not too long time =
ago.
>>>>>>=20
>>>>>>>=20
>>>>>>> Otherwise, the font size is what I would call a normal size.
>>>>>>>=20
>>>>>>>=20
>>>>>>> Acer laptop 11.6"@1366x768:
>>>>>>>=20
>>>>>>> Menu looks fine. Almost fills the entire screen.
>>>>>>>=20
>>>>>>> The font feels a little too big.
>>>>>>=20
>>>>>>=20
>>>>>> The laptop built in displays usually do not give out EDID (we get =
physical dimensions from EDID), so there we fall back to try to get =
80x25 terminal method.
>>>>>=20
>>>>> I am having a hard time with that statement.  EDID is very common =
on laptop screens, infact I can not recall ever not seeing EDID on a =
laptops builtin screen.
>>>>> My 11" acer 1400 has EDID in it.
>>>>>=20
>>>>>=20
>>>>=20
>>>>=20
>>>> If there is EDID, then it is all good. I have seen cases we do not =
get it with available API.
>>>=20
>>> Is there a way for me to know if the laoder found EDID data or not?
>>> It might be that the issue is that what ever loader is using for an =
API is not working.
>>> I based my "EDID is very common on laptop screens" on the fact that =
X11 almost always finds EDID.
>>>=20
>>=20
>> Yes, gop get / vbe list   ? yes, it is inconsistent, should fix at =
some point? :)
>>=20
>> we do use gop get active edid/get discovered edid protocol and vbe =
function 0x4f15.
>=20
> On all my handy laptops, E5470, T400, W530, Acer 1410 edid is present =
and seen
> by the loader.
>=20
>=20

Thank You!

rgds,
toomas




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?FB23EA9A-5D3D-4C96-B639-8822B8542796>