Date: Wed, 25 Dec 2024 16:14:19 +0100 From: Mohammad Noureldin <mohammad@thelightbird.com> To: Tomoaki AOKI <junchoon@dec.sakura.ne.jp> Cc: Joseph Mingrone <jrm@freebsd.org>, hackers@freebsd.org, scottl@freebsd.org, Ed Maste <emaste@freebsd.org> Subject: Re: USB4/TBT3 support Message-ID: <CAAQ96DwGfM2zL26GZaQz=MBv5PDkfpo0RzQD63hmn7vS20zwmA@mail.gmail.com> In-Reply-To: <20241223032523.d9700186b36c60f3ed9b5995@dec.sakura.ne.jp> References: <864j8lmaub.fsf@phe.ftfl.ca> <CAAQ96DyTnbkj4M2cVrHgvcTtPhvz-mKs%2B8bn_NuAqrkkYW5goQ@mail.gmail.com> <20241223032523.d9700186b36c60f3ed9b5995@dec.sakura.ne.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] Hi Tomoaki, 1st of all, thanks a lot for sharing your notes and insights helping to enrich the discussion On Sun, Dec 22, 2024 at 7:25 PM Tomoaki AOKI <junchoon@dec.sakura.ne.jp> wrote: > On Fri, 20 Dec 2024 17:04:20 +0100 > Mohammad Noureldin <mohammad@thelightbird.com> wrote: > <snip> > > Hi. > Thanks for the pointer. > > Some notes: > *hselasky@ (RIP, Hans...) suffered from the lack of official and open > hardware specs for implementing his driver. > > *hselasky@ wasn't going to implement TB3's security features > as it seemed NOT to be sufficient for actual security in spec itself. > > *I have Titan Ridge TB3 controller (falles back to Intel Cannon Lake > USB 3.1 controller when TB3 device is not connected) in my ThinkPad > P52, but hselasky@'s last driver didn't work for it, as his driver > only supports older generation of controller chipset (with the lack > of information). > > *P52 recognizes TB3-only device (Samsung X5 external SSD I've > purchased for test) as internal PCIe drive if it was attached > before powerint on the computer, but hot deplugging causes panic, > with and without hselasky@'s driver installed. > > *My related info are in Bug 237666 [1]. > > [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237666 Believe or not, I was in touch with HPS (may he RIP) over this specific PR given my general interest in USB and I've even purchased 3 2nd hand machines to help testing and get to the root cause: - Dell Precision Tower 5810 -# Which proved not to be useful for this case - Lenovo ThinkPad P52s - Lenovo ThinkPad T480 -# Because Bjoern Zeeb (bz@) could reproduce the original reported issue on this machine and he wrote down some notes about his findings in [1] But that EuroBSDCon of year 2023 when I was planning to bring one or both of these Lenovos with me to tinker on them with HPS, I cam to know that he passed away before the EuroBSDCon's starting date ... RIP HPS. I've added the *"Problem Reports to be Possibly Revisited"* section [2] because in addition to [3] I've noticed other similar PR(s) where we can revisit after a working driver is in place to either: - Indicate that now this works - Or, it still not working, we won't support it, and write this down in a clear way for end users Also to hopefully make the scope more clear, I've added a Scope sub-section [4] > > -- > Tomoaki AOKI <junchoon@dec.sakura.ne.jp> > Thanks again Tomoaki and happy holidays 👊 [1] https://wiki.freebsd.org/BjoernZeeb/USB [2] https://wiki.freebsd.org/MohammadNoureldin/FreeBSDUSB4TBT3Support#Problem_Reports_To_Be_Possibly_Revisited [3] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237666 [4] https://wiki.freebsd.org/MohammadNoureldin/FreeBSDUSB4TBT3Support#Scope -- Thanks - Mohammad Noureldin -- "Life is like riding a bicycle. To keep your balance you must keep moving" - Albert Einstein [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><div dir="ltr">Hi Tomoaki,</div><div><br></div><div>1st of all, thanks a lot for sharing your notes and insights helping to enrich the discussion</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Dec 22, 2024 at 7:25 PM Tomoaki AOKI <<a href="mailto:junchoon@dec.sakura.ne.jp" target="_blank">junchoon@dec.sakura.ne.jp</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Fri, 20 Dec 2024 17:04:20 +0100<br> Mohammad Noureldin <<a href="mailto:mohammad@thelightbird.com" target="_blank">mohammad@thelightbird.com</a>> wrote:<br></blockquote><div><br></div><div><snip></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br> Hi.<br> Thanks for the pointer.<br> <br> Some notes:<br> *hselasky@ (RIP, Hans...) suffered from the lack of official and open<br> hardware specs for implementing his driver.<br> <br> *hselasky@ wasn't going to implement TB3's security features<br> as it seemed NOT to be sufficient for actual security in spec itself.<br> <br> *I have Titan Ridge TB3 controller (falles back to Intel Cannon Lake<br> USB 3.1 controller when TB3 device is not connected) in my ThinkPad<br> P52, but hselasky@'s last driver didn't work for it, as his driver<br> only supports older generation of controller chipset (with the lack<br> of information).<br> <br> *P52 recognizes TB3-only device (Samsung X5 external SSD I've<br> purchased for test) as internal PCIe drive if it was attached<br> before powerint on the computer, but hot deplugging causes panic,<br> with and without hselasky@'s driver installed.<br> <br> *My related info are in Bug 237666 [1].<br> <br> [1] <a href="https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237666" rel="noreferrer" target="_blank">https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237666</a></blockquote><div><br></div><div>Believe or not, I was in touch with HPS (may he RIP) over this specific PR given my general interest in USB and I've even purchased 3 2nd hand machines to help testing and get to the root cause:</div><div>- Dell Precision Tower 5810</div><div>-# Which proved not to be useful for this case</div><div>- Lenovo ThinkPad P52s</div><div>- Lenovo ThinkPad T480</div><div>-# Because Bjoern Zeeb (bz@) could reproduce the original reported issue on this machine and he wrote down some notes about his findings in [1]</div><div> </div><div>But that EuroBSDCon of year 2023 when I was planning to bring one or both of these Lenovos with me to tinker on them with HPS, I cam to know that he passed away before the EuroBSDCon's starting date ... RIP HPS.</div><div><br></div>I've added the <b>"Problem Reports to be Possibly Revisited"</b> section [2] because in addition to [3] I've noticed other similar PR(s) where we can revisit after a working driver is in place to either:</div><div class="gmail_quote">- Indicate that now this works</div><div class="gmail_quote">- Or, it still not working, we won't support it, and write this down in a clear way for end users<br><div><br></div><div>Also to hopefully make the scope more clear, I've added a Scope sub-section [4]</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br> <br> -- <br> Tomoaki AOKI <<a href="mailto:junchoon@dec.sakura.ne.jp" target="_blank">junchoon@dec.sakura.ne.jp</a>><br> </blockquote></div><div><br clear="all"></div><div>Thanks again Tomoaki and happy holidays 👊</div><div><br></div><div>[1] <a href="https://wiki.freebsd.org/BjoernZeeb/USB" target="_blank">https://wiki.freebsd.org/BjoernZeeb/USB</a></div><div>[2] <a href="https://wiki.freebsd.org/MohammadNoureldin/FreeBSDUSB4TBT3Support#Problem_Reports_To_Be_Possibly_Revisited" target="_blank">https://wiki.freebsd.org/MohammadNoureldin/FreeBSDUSB4TBT3Support#Problem_Reports_To_Be_Possibly_Revisited</a></div><div>[3] <a href="https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237666" rel="noreferrer" target="_blank">https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237666</a></div><div>[4] <a href="https://wiki.freebsd.org/MohammadNoureldin/FreeBSDUSB4TBT3Support#Scope">https://wiki.freebsd.org/MohammadNoureldin/FreeBSDUSB4TBT3Support#Scope</a></div><div><br></div><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div dir="ltr" style="color:rgb(136,136,136)">Thanks<br>- Mohammad Noureldin<br>--<br>"Life is like riding a bicycle. To keep your balance you must keep moving"<br>- Albert Einstein</div></div><div dir="ltr" style="color:rgb(136,136,136)"><br></div></div></div></div> </div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAAQ96DwGfM2zL26GZaQz=MBv5PDkfpo0RzQD63hmn7vS20zwmA>