Date: Sat, 12 Apr 2014 13:10:33 +1000 From: Kubilay Kocak <koobs.freebsd@gmail.com> To: John Hein <john.hein@microsemi.com>, python@freebsd.org Subject: Re: [patch] fix PYTHON_VERSION in py-setuptoolsXX Message-ID: <5348AEA9.7030303@FreeBSD.org> In-Reply-To: <21320.42770.726441.667849@gromit.timing.com> References: <21320.42770.726441.667849@gromit.timing.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/04/2014 12:38 PM, John Hein wrote:
> The current settings in py-setuptools{27,32,33,34}/Makefile for
> PYTHON_VERSION are wrong (X.Y instead of pythonX.Y), but sort of work
> by chance rather than design. If it weren't for some unintended luck
> from the way _PYTHON_VERSION is set and the .MAKEFLAGS line in
> bsd.python.mk that forcibly sets
> PYTHON_VERSION=python${_PYTHON_VERSION}, these ports would fail with
> something like:
>
> Makefile error: bad value for PYTHON_VERSION: 3.3.
> Legal values are:
> python2.7 (default)
> python3.1
> python3.2
> python3.3
> python3.4
>
>
> Please fix:
>
> Index: py-setuptools27/Makefile
> ===================================================================
> --- py-setuptools27/Makefile (revision 350922)
> +++ py-setuptools27/Makefile (working copy)
> @@ -3,7 +3,7 @@
>
> PKGNAMESUFFIX= ${PYTHON_SUFFIX}
>
> -PYTHON_VERSION= 2.7
> +PYTHON_VERSION= python2.7
>
> MASTERDIR= ${.CURDIR}/../py-setuptools
>
> Index: py-setuptools32/Makefile
> ===================================================================
> --- py-setuptools32/Makefile (revision 350922)
> +++ py-setuptools32/Makefile (working copy)
> @@ -3,7 +3,7 @@
>
> PKGNAMESUFFIX= ${PYTHON_SUFFIX}
>
> -PYTHON_VERSION= 3.2
> +PYTHON_VERSION= python3.2
>
> MASTERDIR= ${.CURDIR}/../py-setuptools
>
> Index: py-setuptools33/Makefile
> ===================================================================
> --- py-setuptools33/Makefile (revision 350922)
> +++ py-setuptools33/Makefile (working copy)
> @@ -3,7 +3,7 @@
>
> PKGNAMESUFFIX= ${PYTHON_SUFFIX}
>
> -PYTHON_VERSION= 3.3
> +PYTHON_VERSION= python3.3
>
> MASTERDIR= ${.CURDIR}/../py-setuptools
>
> Index: py-setuptools34/Makefile
> ===================================================================
> --- py-setuptools34/Makefile (revision 350922)
> +++ py-setuptools34/Makefile (working copy)
> @@ -3,7 +3,7 @@
>
> PKGNAMESUFFIX= ${PYTHON_SUFFIX}
>
> -PYTHON_VERSION= 3.4
> +PYTHON_VERSION= python3.4
>
> MASTERDIR= ${.CURDIR}/../py-setuptools
>
>
> _______________________________________________
> freebsd-python@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-python
> To unsubscribe, send any mail to "freebsd-python-unsubscribe@freebsd.org"
>
Thanks for the report John (and the one directly to me for bsd.python.mk)
Can you also submit a PR so it can be tracked please. We use these for
our quarterly reports among other things. This will also ensure you are
notified when progress is made.
./koobs
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5348AEA9.7030303>