Date: Fri, 5 May 2017 12:17:06 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Franco Fichtner <franco@lastsummer.de>, Mathieu Arnold <mat@FreeBSD.org> Cc: Aristedes Maniatis <ari@ish.com.au>, FreeBSD Mailing List <freebsd-ports@freebsd.org> Subject: Re: diff and submissions Message-ID: <05fd8f53-30b8-88fb-4d70-68637b2261b1@FreeBSD.org> In-Reply-To: <22B42BD4-B348-49F6-8CF6-82B7B00E6B84@lastsummer.de> References: <750748ab-0e0e-cbb2-0b3b-d236829ee958@ish.com.au> <063dd680-2600-b440-b06b-04323eed6e58@FreeBSD.org> <22B42BD4-B348-49F6-8CF6-82B7B00E6B84@lastsummer.de>
next in thread | previous in thread | raw e-mail | index | archive | help
Le 05/05/2017 =C3=A0 08:16, Franco Fichtner a =C3=A9crit : >> On 4. May 2017, at 10:20 AM, Mathieu Arnold <mat@FreeBSD.org> wrote: >> >> If you went as far as being able to create a pull request, you can do = a >> git show HEAD or git diff origin/trunk...HEAD and submit that in the >> FreeBSD PR as well. > It's pretty easy to extract the diff from a PR on GitHub, just append > ".diff", and ".patch" works too, but gives the full git commit history:= > > https://github.com/freebsd/freebsd-ports/pull/62.diff Yes, I am aware of that, the problem with github pull requests is that they are outside of the FreeBSD bug report process, they do not get assigned to maintainers, nobody notices them, they just stay there, and get obsolete. There have been 61 before, yes, I closed a lot because they were obsolete because it is outside of our process and nobody noticed them, and for the rest either asked the submitter to open a PR on our bugzilla, or opened one myself. --=20 Mathieu Arnold
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?05fd8f53-30b8-88fb-4d70-68637b2261b1>