Date: Tue, 4 Jul 2023 15:42:34 +0100 From: Nuno Teixeira <eduardo@freebsd.org> To: Dimitry Andric <dim@freebsd.org> Cc: Danilo Egea Gondolfo <danilo@freebsd.org>, FreeBSD Ports <ports@freebsd.org> Subject: Re: glib2 deprecated declarations failing on clang16 Message-ID: <CAFDf7UJmiM8Lk4Ua--h2YY6WCwsNgXDHnPJrv4YaJCyGqj3fAw@mail.gmail.com> In-Reply-To: <22F61A7B-3566-4761-8D7A-DC78B9CF20E6@FreeBSD.org> References: <CAFDf7U%2B-M1D7xL_AkB-eY%2B0jq2JjjdhzoZUZtnmanVoa25vOtQ@mail.gmail.com> <BBD89BC1-8E9D-4E6D-887E-4A785F4A21D4@FreeBSD.org> <ffcb1751-dc86-b241-d7aa-f54896851697@FreeBSD.org> <CAFDf7ULBM1pV_X6OeRKbEggfyGcd0j-LuF720usWtM8KaG%2BJFA@mail.gmail.com> <22F61A7B-3566-4761-8D7A-DC78B9CF20E6@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000d4e23b05ffaa4b3b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable And run test sucess at main-n263935-e8423423737e I will do more testport builds with gtk2 and gtk3. I will use something like in commit msg: --- Fix build with clang16 Use G_CALLBACK() macro to silence incompatible function pointer warnings an= d disables any argument checks. Reported by: dim --- Cheers, Dimitry Andric <dim@freebsd.org> escreveu no dia ter=C3=A7a, 4/07/2023 =C3= =A0(s) 15:31: > I got to exactly the same patches. This is due to how glib's gclosure.h > header declares its callback function type as '(void)', even though in > reality the number and type of the arguments varies: > > /** > * GCallback: > * > * The type used for callback functions in structure definitions and > function > * signatures. > * > * This doesn't mean that all callback functions must take no > parameters and > * return void. The required signature of a callback function is > determined by > * the context in > which is used (e.g. the signal to which it is connected). > * > * Use G_CALLBACK() to cast the callback function to a #GCallback. > */ > typedef void (*GCallback) (void); > > It would have been better if glib had just used '(...)', but the > solution they have chosen requires each callback function to be cast > using the G_CALLBACK() macro. > > That basically shuts up any incompatible function pointer warnings, and > disables any argument checks. > > -Dimitry > > > On 4 Jul 2023, at 16:21, Nuno Teixeira <eduardo@freebsd.org> wrote: > > > > Hello Danilo! > > > > Yes, it builds ok. > > > > I will do a run test tomorrow on bluefish. > > > > Any hint on how to explain it in commit: > > > > --- > > --- src/bftextview2_autocomp.c.orig 2023-07-04 14:09:37 UTC > > +++ src/bftextview2_autocomp.c > > @@ -429,7 +429,7 @@ acwin_create(BluefishTextView * btv) > > /*gtk_widget_set_size_request(acw->reflabel,150,-1); */ > > gtk_widget_show_all(acw->scroll); > > gtk_widget_show(hbox); > > - g_signal_connect(acw->reflabel, "activate-link", > acw_label_active_link_lcb, acw); > > + g_signal_connect(acw->reflabel, "activate-link", > G_CALLBACK(acw_label_active_link_lcb), acw); > > /*gtk_widget_set_size_request(GTK_WIDGET(acw->tree),100,200); *= / > > /*gtk_widget_set_size_request(acw->win, 150, 200); */ > > > /*g_signal_connect(G_OBJECT(acw->win),"key-release-event",G_CALLBACK(acw= in_key_release_lcb),acw); > */ > > --- > > and > > --- > > --- src/external_commands.c.orig 2023-07-04 14:12:18 UTC > > +++ src/external_commands.c > > @@ -483,7 +483,7 @@ create_commandstring(Texternalp * ep, const gchar * > fo > > > gtk_dialog_set_default_response(GTK_DIALOG(dialog),GTK_RESPONSE_ACCEPT); > > tmp =3D g_strdup_printf(_("Supply arguments to define %= %a > in '%s'"), formatstring); > > entry =3D dialog_entry_labeled(NULL, tmp, > gtk_dialog_get_content_area(GTK_DIALOG(dialog)), 6); > > - g_signal_connect(G_OBJECT(entry), "activate", > command_dialog_entry_activated_lcb, dialog); > > + g_signal_connect(G_OBJECT(entry), "activate", > G_CALLBACK(command_dialog_entry_activated_lcb), dialog); > > g_free(tmp); > > gtk_widget_show_all(dialog); > > result =3D gtk_dialog_run(GTK_DIALOG(dialog)); > > --- > > > > Thanks! > > > > Danilo Egea Gondolfo <danilo@freebsd.org> escreveu no dia ter=C3=A7a, > 4/07/2023 =C3=A0(s) 15:00: > > On 04/07/2023 14:56, Dimitry Andric wrote: > > > > > On 4 Jul 2023, at 14:37, Nuno Teixeira <eduardo@freebsd.org> wrote: > > >> I'm getting build errors from current with www/bluefish about > deprecated glib2 declarations and causing build to fail with clang16: > > >> --- > > >> /usr/local/include/glib-2.0/glib/gmacros.h:1262:37: note: expanded > from macro 'G_DEPRECATED' > > >> #define G_DEPRECATED __attribute__((__deprecated__)) > > >> ^ > > >> mv -f .deps/bluefish.Tpo .deps/bluefish.Po > > >> bftextview2_langmgr.c:2665:2: warning: 'g_thread_create_full' is > deprecated: Use 'g_thread_new' instead [-Wdeprecated-declarations] > > >> g_thread_create_full(build_bflang2scan_thread, NULL, 0, > FALSE, FALSE, G_THREAD_PRIORITY_LOW, &gerror); > > >> --- > > >> > > >> Any help is welcome on finding out its cause. > > >> > > >> a related issue: https://github.com/PCSX2/pcsx2/issues/3315 > > >> > > >> Build log: > https://pkg-status.freebsd.org/beefy17/data/main-i386-default/pf46bd2c584= 25_s0631830a7a/logs/bluefish-2.2.14.log > > > The actual error is an incompatible callback function signature: > > > > > > bftextview2_autocomp.c:432:2: error: incompatible function pointer > types passing 'gboolean (GtkLabel *, gchar *, gpointer)' (aka 'int (struc= t > _GtkLabel *, char *, void *)') to parameter of type 'GCallback' (aka 'voi= d > (*)(void)') [-Wincompatible-function-pointer-types] > > > g_signal_connect(acw->reflabel, "activate-link", > acw_label_active_link_lcb, acw); > > > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~~~~~~ > > > /usr/local/include/glib-2.0/gobject/gsignal.h:515:59: note: expanded > from macro 'g_signal_connect' > > > g_signal_connect_data ((instance), (detailed_signal), (c_handler), > (data), NULL, (GConnectFlags) 0) > > > ^~~~~~~~~~~ > > > /usr/local/include/glib-2.0/gobject/gsignal.h:411:25: note: passing > argument to parameter 'c_handler' here > > > GCallback c_handler, > > > ^ > > > > > > I have seen these more often with glib-based applications. In some > cases > > > it is feasible to fix the callback function to have the correct > > > signature, in other cases you can slap a cast in place. Or, if the > > > affected code is vala-generated (also happens), the big hammer is to > > > suppress the warning(s). > > > > > > -Dimitry > > > > > Not a glib expert here, but you can try this > https://pastebin.com/ty8hLjVU > > > > > > > > -- > > Nuno Teixeira > > FreeBSD Committer (ports) > > --=20 Nuno Teixeira FreeBSD Committer (ports) --000000000000d4e23b05ffaa4b3b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>And run test sucess at main-n263935-e8423423737e</div= ><div><br></div><div>I will do more testport builds with gtk2 and gtk3.</di= v><div><br></div><div>I will use something like in commit msg:</div><div>--= -</div><div>Fix build with clang16<br></div><div>Use G_CALLBACK() macro to = silence incompatible function pointer warnings and<br> disables any argument checks.<br><br>Reported by: dim<br>---</div><div><br>= </div><div>Cheers,<br></div></div><br><div class=3D"gmail_quote"><div dir= =3D"ltr" class=3D"gmail_attr">Dimitry Andric <<a href=3D"mailto:dim@free= bsd.org">dim@freebsd.org</a>> escreveu no dia ter=C3=A7a, 4/07/2023 =C3= =A0(s) 15:31:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0p= x 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I = got to exactly the same patches. This is due to how glib's gclosure.h<b= r> header declares its callback function type as '(void)', even though= in<br> reality the number and type of the arguments varies:<br> <br> =C2=A0 /**<br> =C2=A0 =C2=A0* GCallback:<br> =C2=A0 =C2=A0*<br> =C2=A0 =C2=A0* The type used for callback functions in structure definition= s and function<br> =C2=A0 =C2=A0* signatures.<br> =C2=A0 =C2=A0*<br> =C2=A0 =C2=A0* This doesn't mean that all callback functions must take = no=C2=A0 parameters and<br> =C2=A0 =C2=A0* return void. The required signature of a callback function i= s determined by=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 * the context i= n which is used (e.g. the signal to which it is connected).<br> =C2=A0 =C2=A0*<br> =C2=A0 =C2=A0* Use G_CALLBACK() to cast the callback function to a #GCallba= ck.<br> =C2=A0 =C2=A0*/<br> =C2=A0 typedef void=C2=A0 (*GCallback)=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 (void);<br> <br> It would have been better if glib had just used '(...)', but the<br= > solution they have chosen requires each callback function to be cast<br> using the G_CALLBACK() macro.<br> <br> That basically shuts up any incompatible function pointer warnings, and<br> disables any argument checks.<br> <br> -Dimitry<br> <br> > On 4 Jul 2023, at 16:21, Nuno Teixeira <<a href=3D"mailto:eduardo@f= reebsd.org" target=3D"_blank">eduardo@freebsd.org</a>> wrote:<br> > <br> > Hello Danilo!<br> > <br> > Yes, it builds ok.<br> > <br> > I will do a run test tomorrow on bluefish.<br> > <br> > Any hint on how to explain it in commit:<br> > <br> > ---<br> > --- src/bftextview2_autocomp.c.orig=C2=A0 =C2=A0 =C2=A02023-07-04 14:0= 9:37 UTC<br> > +++ src/bftextview2_autocomp.c<br> > @@ -429,7 +429,7 @@ acwin_create(BluefishTextView * btv)<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0/*gtk_widget_set_size_request(acw->= ;reflabel,150,-1); */<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0gtk_widget_show_all(acw->scroll);<= br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0gtk_widget_show(hbox);<br> > -=C2=A0 =C2=A0 =C2=A0 =C2=A0g_signal_connect(acw->reflabel, "a= ctivate-link", acw_label_active_link_lcb, acw);<br> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0g_signal_connect(acw->reflabel, "a= ctivate-link", G_CALLBACK(acw_label_active_link_lcb), acw);<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0/*gtk_widget_set_size_request(GTK_WID= GET(acw->tree),100,200); */<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0/*gtk_widget_set_size_request(acw->= ;win, 150, 200); */<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0/*g_signal_connect(G_OBJECT(acw->w= in),"key-release-event",G_CALLBACK(acwin_key_release_lcb),acw); *= /<br> > ---<br> > and<br> > ---<br> > --- src/external_commands.c.orig=C2=A0 =C2=A0 =C2=A0 =C2=A0 2023-07-04= 14:12:18 UTC<br> > +++ src/external_commands.c<br> > @@ -483,7 +483,7 @@ create_commandstring(Texternalp * ep, const gchar = * fo<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0gtk_dialo= g_set_default_response(GTK_DIALOG(dialog),GTK_RESPONSE_ACCEPT);<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0tmp =3D g= _strdup_printf(_("Supply arguments to define %%a in '%s'"= ), formatstring);<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0entry =3D= dialog_entry_labeled(NULL, tmp, gtk_dialog_get_content_area(GTK_DIALOG(dia= log)), 6);<br> > -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0g_signal_conne= ct(G_OBJECT(entry), "activate", command_dialog_entry_activated_lc= b, dialog);<br> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0g_signal_conne= ct(G_OBJECT(entry), "activate", G_CALLBACK(command_dialog_entry_a= ctivated_lcb), dialog);<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0g_free(tm= p);<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0gtk_widge= t_show_all(dialog);<br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0result = =3D gtk_dialog_run(GTK_DIALOG(dialog));<br> > ---<br> > <br> > Thanks!<br> > <br> > Danilo Egea Gondolfo <<a href=3D"mailto:danilo@freebsd.org" target= =3D"_blank">danilo@freebsd.org</a>> escreveu no dia ter=C3=A7a, 4/07/202= 3 =C3=A0(s) 15:00:<br> > On 04/07/2023 14:56, Dimitry Andric wrote:<br> > <br> > > On 4 Jul 2023, at 14:37, Nuno Teixeira <<a href=3D"mailto:edua= rdo@freebsd.org" target=3D"_blank">eduardo@freebsd.org</a>> wrote:<br> > >> I'm getting build errors from current with www/bluefish a= bout deprecated glib2 declarations and causing build to fail with clang16:<= br> > >> ---<br> > >> /usr/local/include/glib-2.0/glib/gmacros.h:1262:37: note: exp= anded from macro 'G_DEPRECATED'<br> > >> #define G_DEPRECATED __attribute__((__deprecated__))<br> > >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^<br= > > >> mv -f .deps/bluefish.Tpo .deps/bluefish.Po<br> > >> bftextview2_langmgr.c:2665:2: warning: 'g_thread_create_f= ull' is deprecated: Use 'g_thread_new' instead [-Wdeprecated-de= clarations]<br> > >>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 g_thread_create_full(build_= bflang2scan_thread, NULL, 0, FALSE, FALSE, G_THREAD_PRIORITY_LOW, &gerr= or);<br> > >> ---<br> > >><br> > >> Any help is welcome on finding out its cause.<br> > >><br> > >> a related issue: <a href=3D"https://github.com/PCSX2/pcsx2/is= sues/3315" rel=3D"noreferrer" target=3D"_blank">https://github.com/PCSX2/pc= sx2/issues/3315</a><br> > >><br> > >> Build log: <a href=3D"https://pkg-status.freebsd.org/beefy17/= data/main-i386-default/pf46bd2c58425_s0631830a7a/logs/bluefish-2.2.14.log" = rel=3D"noreferrer" target=3D"_blank">https://pkg-status.freebsd.org/beefy17= /data/main-i386-default/pf46bd2c58425_s0631830a7a/logs/bluefish-2.2.14.log<= /a><br> > > The actual error is an incompatible callback function signature:<= br> > ><br> > > bftextview2_autocomp.c:432:2: error: incompatible function pointe= r types passing 'gboolean (GtkLabel *, gchar *, gpointer)' (aka = 9;int (struct _GtkLabel *, char *, void *)') to parameter of type '= GCallback' (aka 'void (*)(void)') [-Wincompatible-function-poin= ter-types]<br> > > g_signal_connect(acw->reflabel, "activate-link", acw= _label_active_link_lcb, acw);<br> > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~~~~~~~~~~~~~~<br> > > /usr/local/include/glib-2.0/gobject/gsignal.h:515:59: note: expan= ded from macro 'g_signal_connect'<br> > > g_signal_connect_data ((instance), (detailed_signal), (c_handler)= , (data), NULL, (GConnectFlags) 0)<br> > > ^~~~~~~~~~~<br> > > /usr/local/include/glib-2.0/gobject/gsignal.h:411:25: note: passi= ng argument to parameter 'c_handler' here<br> > > GCallback c_handler,<br> > > ^<br> > ><br> > > I have seen these more often with glib-based applications. In som= e cases<br> > > it is feasible to fix the callback function to have the correct<b= r> > > signature, in other cases you can slap a cast in place. Or, if th= e<br> > > affected code is vala-generated (also happens), the big hammer is= to<br> > > suppress the warning(s).<br> > ><br> > > -Dimitry<br> > ><br> > Not a glib expert here, but you can try this <a href=3D"https://pasteb= in.com/ty8hLjVU" rel=3D"noreferrer" target=3D"_blank">https://pastebin.com/= ty8hLjVU</a><br> > <br> > <br> > <br> > --<br> > Nuno Teixeira<br> > FreeBSD Committer (ports)<br> <br> </blockquote></div><br clear=3D"all"><br><span class=3D"gmail_signature_pre= fix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"l= tr"><span style=3D"color:rgb(102,102,102)">Nuno Teixeira<br>FreeBSD Committ= er (ports)</span></div></div> --000000000000d4e23b05ffaa4b3b--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7UJmiM8Lk4Ua--h2YY6WCwsNgXDHnPJrv4YaJCyGqj3fAw>