Date: Thu, 10 Apr 2014 15:24:37 -0700 From: Garrett Cooper <yaneurabeya@gmail.com> To: Julio Merino <jmmv@freebsd.org> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org> Subject: Re: Makefiles for skip-level directories? Message-ID: <CAGHfRMAHe9GWCuc3LS-ve7PmVnquuNihr6E_nOe6UYuKOy5v6w@mail.gmail.com> In-Reply-To: <2BC2387E-387B-46EC-832F-78ECEA51A206@freebsd.org> References: <16437CC5729B5345AF77F816513376E8129868F1@MX103CL02.corp.emc.com> <CAFY7cWD2A_B949Fp7Pp5rKysNbQE_LqBJh%2BwYD1-v8uGcLEXBw@mail.gmail.com> <16437CC5729B5345AF77F816513376E820BAA20A@MX103CL02.corp.emc.com> <CAFY7cWD52sSES%2BLqFr6T6-=WREF7iF=HGTDuKov4NhJ9_dmxng@mail.gmail.com> <16437CC5729B5345AF77F816513376E820BACB49@MX103CL02.corp.emc.com> <2194A8F0-810B-471A-AD9C-C95C469EAD99@gmail.com> <2BC2387E-387B-46EC-832F-78ECEA51A206@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Apr 10, 2014 at 3:19 PM, Julio Merino <jmmv@freebsd.org> wrote: >> >> Yeah, bsd.own.mk is redundant, but it doesn't do any harm minus a hit on the cache, and increase the file sizes a small amount. >> >> In the event that the Makefile snippet would be removed from the included makefiles then stuff would break horribly. Plus it makes it clear that MK_TESTS is obtained from bsd.own.mk. > > bsd.own.mk is not redundant if you are going to test for MK_TESTS; you need that include. > > What I'm not clear about is if bsd.own.mk ought to be bsd.init.mk or not. Unfortunately changing this would break a lot of things that have worked in the past, so I think it's best to leave this alone :/.. -Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGHfRMAHe9GWCuc3LS-ve7PmVnquuNihr6E_nOe6UYuKOy5v6w>