Date: Sat, 24 Feb 2024 09:32:00 +0000 From: =?utf-8?Q?Einar_Bjarni_Halld=C3=B3rsson?= <einar@isnic.is> To: Nuno Teixeira <eduardo@freebsd.org> Cc: ports@freebsd.org Subject: Re: Multiple new R ports Message-ID: <6A36BE5B-2C76-434D-8EFF-D9518DA7E6E6@isnic.is> In-Reply-To: <2E6761A6-F462-4B83-94AC-9658583A581D@isnic.is> References: <44F61FC1-532F-447F-80E9-83ED37599CD7@isnic.is> <CALH631nPt94VcQnsh5_CQHnGkb-5uVvRotFGWWoj4wRtNveXUQ@mail.gmail.com> <AD61A7F4-D5CC-487D-A08A-47267FD69052@isnic.is> <16c2bf5c-9022-4ce9-9283-838f99d80ba3@isnic.is> <CAFDf7U%2BG2v5eQ2OJq76d2f3UGht9J1kTstFECAaqqnPPq5QUvA@mail.gmail.com> <2E6761A6-F462-4B83-94AC-9658583A581D@isnic.is>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 24 Feb 2024, at 06:24, Einar Bjarni Halld=C3=B3rsson = <einar@isnic.is> wrote: >=20 >> On 22 Feb 2024, at 11:43, Nuno Teixeira <eduardo@freebsd.org> wrote: >>=20 >> I did take a look at review and noticed that TEST_DEPENDS are not = used >> and that could means that test target works without any depends or >> ports are not tested at all. >> My curiosity is what do you think about the importance (or not) to >> have testunit feature working on R ports? >>=20 I=E2=80=99ve got tests working on all the ports, except for = R-cran-systemfonts. I have a PR [1] for upstream to fix that. Tests do give out notice that suggested packages aren=E2=80=99t = installed to be tested, what=E2=80=99s your opinion on that? I don=E2=80=99t want to add too = much to the packages and I definately don=E2=80=99t want to add options at this moment. Would it be fine to add the ports as is, without suggested packages? .einar [1] https://github.com/r-lib/systemfonts/pull/111=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6A36BE5B-2C76-434D-8EFF-D9518DA7E6E6>