Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 17 Feb 2024 09:29:04 +0000
From:      Nuno Teixeira <eduardo@freebsd.org>
To:        Moin Rahman <bofh@freebsd.org>
Cc:        FreeBSD Mailing List <freebsd-ports@freebsd.org>
Subject:   Re: libX changed its libnameA.h to libnameB.h
Message-ID:  <CAFDf7UJqpFJBRE5uXyigkUDAGtxi8phQTcoTz4W3eSBv_HvzhQ@mail.gmail.com>
In-Reply-To: <2F2001CB-8433-4B56-8303-23D3C8E40E42@freebsd.org>
References:  <CAFDf7UKmhvqN3uu5BoEBpqMd3o3pZDeBp2J1=0uavpaYyfKn6g@mail.gmail.com> <47C52E85-141A-4FF1-BCD2-9ACBE50CDE27@freebsd.org> <CAFDf7UKn-jEXoT0KauEVqRK1LYVv=6R9mfvYZFsstbi-gV4D1Q@mail.gmail.com> <2F2001CB-8433-4B56-8303-23D3C8E40E42@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Yes, a new api for sure. Replacing .h file:

../src/backend_libnsgif.c:17:3: error: unknown type name 'gif_animation'
   17 |   gif_animation gif;
      |   ^
../src/backend_libnsgif.c:55:8: error: unknown type name
'gif_bitmap_callback_vt'
   55 | static gif_bitmap_callback_vt bitmap_callbacks =3D {
      |        ^
../src/backend_libnsgif.c:72:3: warning: call to undeclared function
'gif_finalise'; ISO C99 and later do not support implicit function
declarations [-Wimplicit-function-declaration]
   72 |   gif_finalise(&private->gif);
      |   ^
../src/backend_libnsgif.c:100:3: error: use of undeclared identifier
'gif_result'
  100 |   gif_result code =3D gif_decode_frame(&private->gif,
private->current_frame);
      |   ^
../src/backend_libnsgif.c:101:7: error: use of undeclared identifier
'code'; did you mean 'close'?
  101 |   if (code !=3D GIF_OK) {
      |       ^~~~
      |       close
/usr/include/unistd.h:324:6: note: 'close' declared here
  324 | int      close(int);
      |          ^
../src/backend_libnsgif.c:101:15: error: use of undeclared identifier
'GIF_OK'; did you mean 'NSGIF_OK'?
  101 |   if (code !=3D GIF_OK) {
      |               ^~~~~~
      |               NSGIF_OK


I will see if lib have some kind of compability with old version and
if not I will disable this port option and put it as broken.

Moin Rahman <bofh@freebsd.org> escreveu (s=C3=A1bado, 17/02/2024 =C3=A0(s) =
08:46):
>
>
>
> > On Feb 17, 2024, at 9:43 AM, Nuno Teixeira <eduardo@freebsd.org> wrote:
> >
> > Hello Moin!
> >
> > I will try rename on src code and check if functionality is ok.
> >
> > Just a question: is it normal a lib do such changes?
> Not at all.
>
> > Taking a look at changelog I can't see nothing related:
> > https://www.mail-archive.com/netsurf-commits@netsurf-browser.org/msg173=
36.html
> >
> > It smells like new API... In that case, consumers should change to supp=
ort it.
> In that case you have run out of luck. :D
>
> > Cheers,
> >
> >
> > Moin Rahman <bofh@freebsd.org> escreveu (s=C3=A1bado, 17/02/2024 =C3=A0=
(s) 08:11):
> >>
> >>
> >>
> >>> On Feb 17, 2024, at 9:08 AM, Nuno Teixeira <eduardo@freebsd.org> wrot=
e:
> >>>
> >>> Hello all,
> >>>
> >>> I'm facing a build error causes from graphics/libnsgif that changed
> >>> from 0.2.1 to 1.0.0:
> >>> -include/libnsgif.h
> >>> +include/nsgif.h
> >>>
> >>> Now graphics/imv complains:
> >>>
> >>> ./src/backend_libnsgif.c:9:10: fatal error: 'libnsgif.h' file not fou=
nd
> >>>   9 | #include <libnsgif.h>
> >>>     |          ^~~~~~~~~~~~
> >>> 1 error generated.
> >>>
> >>> While I'm looking from upstream recomendation on fix, how do I quick =
fix it?
> >>> Is it possible to rename libnsgif.h -> nsgif.h in source code?
> >>>
> >>> Also googling about this issue didn't get results since most img pkgs
> >>> do not have this lib default on.
> >>>
> >>> Thanks,
> >>>
> >>> --
> >>> Nuno Teixeira
> >>> FreeBSD Committer (ports)
> >>>
> >>
> >> Depends. If the function names and arguments are also same you can jus=
t
> >> rename in the source code.
> >>
> >>
> >
> >
> > --
> > Nuno Teixeira
> > FreeBSD Committer (ports)
>


--=20
Nuno Teixeira
FreeBSD Committer (ports)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7UJqpFJBRE5uXyigkUDAGtxi8phQTcoTz4W3eSBv_HvzhQ>