Date: Wed, 21 Jan 2009 10:58:58 +0100 From: "Paul B. Mahol" <onemda@gmail.com> To: Jack Vogel <jfvogel@gmail.com> Cc: Eitan Shefi <eitans@mellanox.co.il>, Angelo Turetta <aturetta@bestunion.it>, Sam Leffler <sam@freebsd.org>, Yony Yossef <yonyossef.lists@gmail.com>, freebsd-net@freebsd.org Subject: Re: VLAN interface management - unloading carrying driver hangs the machine Message-ID: <3a142e750901210158p75ee5606oa83275f343b93b86@mail.gmail.com> In-Reply-To: <2a41acea0901080109l6189b379q4a348cc80527e90e@mail.gmail.com> References: <000001c970a8$3fa45240$220f000a@mtl.com> <4964C2E9.1060301@bestunion.it> <000001c970d9$4403e590$220f000a@mtl.com> <4964EC4F.8030507@freebsd.org> <2a41acea0901071359w3f41465ajb8206cdef5b7b680@mail.gmail.com> <49652E25.9030705@freebsd.org> <000601c97169$b85717b0$220f000a@mtl.com> <2a41acea0901080109l6189b379q4a348cc80527e90e@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 1/8/09, Jack Vogel <jfvogel@gmail.com> wrote: > Fine with me, go do it and I'll take the driver code out :) > > Jack > > > On Thu, Jan 8, 2009 at 12:18 AM, Yony Yossef > <yonyossef.lists@gmail.com>wrote: > >> > Jack Vogel wrote: >> > > >> > > >> > > On Wed, Jan 7, 2009 at 9:54 AM, Sam Leffler <sam@freebsd.org >> > > <mailto:sam@freebsd.org>> wrote: >> > > >> > > Yony Yossef wrote: >> > > >> > > Yony Yossef wrote: >> > > >> > > >> > > /sbin/ifconfig vlan3653 create >> > > >> > > Problem is when I assign an IP to the vlan >> > interface. >> > > In that case, unloading the driver results >> > in hanging >> > > the host. >> > > Does it sound familiar to anybody? >> > > >> > > >> > > Well, surely I'd expect problems by doing so. >> > > The correct way is to >> > > >> > > /sbin/ifconfig vlan3653 destroy >> > > >> > > before unloading the driver. >> > > >> > > Angelo. >> > > >> > > >> > > >> > > Thanks, I didn't know freebsd does not allow it. >> > > >> > > >> > > >> > > This seems wrong. Someone should disallow the driver >> > > detach/unload. Please file a PR about this so the issue >> > is not lost. >> > > >> > > Sam >> > > >> > > >> > > In many drivers, ahem, like mine, there is a test at detach and it >> > > will not allow it if there is a non-NULL trunk. >> > > >> > > Sounds like a broken driver needs to be fixed is all... >> > > >> > I don't agree; drivers should not be required to deal with >> > this. If someone files a PR and assigns it to me I'll look at it. >> > >> > Sam >> > >> >> I agree with Sam. There's no reason to leave this check to the driver. >> >> Yony >> >> > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > What's the state of this issue? It is fixed or not? -- Paul
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3a142e750901210158p75ee5606oa83275f343b93b86>