Date: Sun, 27 Nov 2016 13:57:16 +0100 From: Willem Jan Withagen <wjw@digiware.nl> To: Mathieu Arnold <mat@FreeBSD.org>, "ports@freebsd.org" <ports@freebsd.org> Subject: Re: running make makesum for multiple github repos Message-ID: <b2ccf320-1dc8-6b1a-c899-15e215a2e018@digiware.nl> In-Reply-To: <2a5f6706-ec7b-097c-0879-d0e8e85b203b@FreeBSD.org> References: <14fe8d55-2d90-d722-653e-ff2df119b408@digiware.nl> <c421545d-5803-c887-da68-ae6594e67c47@FreeBSD.org> <e595a117-e8c3-5e2f-dce2-1ca21d41d70a@digiware.nl> <2a5f6706-ec7b-097c-0879-d0e8e85b203b@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 27-11-2016 13:34, Mathieu Arnold wrote:
> Le 27/11/2016 à 12:57, Willem Jan Withagen a écrit :
>> On 26-11-2016 21:10, Mathieu Arnold wrote:
>>> Le 25/11/2016 à 12:46, Willem Jan Withagen a écrit :
>>>> Hi,
>>>>
>>>> I'm try in to make a port for Ceph, but it depens on a lot of github
>>>> modules.
>>> From having a quick look at the GH_TUPLE, it seems you have duplicate
>>> tags, the fourth field. You seem to always put :ceph, but it *must* be
>>> unique.
>>>
>>> Also, you are using master at least twice, you must not use branch
>>> names, you must put tags or commit hashes.
>> Hi Mathieu,
>>
>> Your remarks pushed me in the right direction.
>> I needed to fix two things:
>> Fetching all the repos, and they needed to be IN the tree that is
>> fetched with master.
>>
>> So indeed the fourth field (which is called group) needs to be
>> different, then all the repos are fetched. Placing them in
>> subdirectories of ${WRKSRC} is done by adding the path after a / after
>> the group.
>>
>> IMHO a sort of an illogical last element of GH_TUPLE. And perhaps
>> deserves a bit/lot more explaining in the handbook.
>
> It is all documented in the USE_GITHUB section[1] of the Porter's
> Handbook. The format of GH_TUPLE is described there too, and there are a
> few examples, including one extended one describing what you are trying
> to do.
I have reread the section, but still cannot really understand what I did
from the text... But that perhaps says more about me. :)
Perhaps it would help if the group/subdir is a more verbosely explained.
It, for one, does not tell that group needs to be exclusive for each
repo. And I still have no clue as to its function.
In the fourth field the group is required, and subdir is optional.
> The GH_TUPLE format is a bit strange, I agree, but the subdirectory
> could not be put in another place because the third field (commit or
> tag) can contain a / (there are a few examples in the tree), and the
> path can contain a : (I stumbled upon one).
> Also, GH_SUBDIR is optional, and it was a bad idea to put an optional
> part in the middle of the string.
> (And I'm not talking about the fact that GH_SUBDIR is newer than
> GH_TUPLE, and that backward compatibility needed to be kept.)
GH_TUPLE is also not very often used in the ports. So there are not that
many examples to find. And I appreciate backwards compatibility, and
starting to escape chars will not make it more ledgible.
>> It now looks like:
>> GH_TUPLE+= ceph:xxHash:v0.5.1-2-g1f40c65:xxHash/src/xxHash
>> GH_TUPLE+= ceph:isa-l:v2.16.0:isal/src/isa-l
>> GH_TUPLE+= ceph:lua:lua-5.3-ceph:lua/src/lua
>> GH_TUPLE+= ceph:Beast:999e2fa:Beast/src/Beast
>> GH_TUPLE+= boostorg:boost:boost-1.61.0-275-g1790aff:boost/src/boost
>> GH_TUPLE+= ceph:dpdk:a38e5ec:dpd/src/dpd
>
> 1:
> https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github
>
That is where i got my info...
Thanx,
--WjW
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b2ccf320-1dc8-6b1a-c899-15e215a2e018>