Date: Thu, 31 Dec 2020 19:03:37 -0500 From: Ed Maste <emaste@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: Li-Wen Hsu <lwhsu@freebsd.org>, git@freebsd.org Subject: Re: Thoughts on git commit mail Message-ID: <CAPyFy2BURCr1aW4A_8VbZaXFUsfVTvm92Mco5nqUGmRXDOJiKA@mail.gmail.com> In-Reply-To: <2bff94da-deb9-2410-b580-441eb31c8d40@FreeBSD.org> References: <f90b2357-f13a-44da-42b7-c439f033f218@FreeBSD.org> <CAKBkRUwP53fV3qGUgvDMyqbURtqQdqdTj3bvOsdc2Xya1s9now@mail.gmail.com> <2bff94da-deb9-2410-b580-441eb31c8d40@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 31 Dec 2020 at 17:14, John Baldwin <jhb@freebsd.org> wrote:
>
> The mix of fields for name and date is a bit odd though. Perhaps another
> alternative might be to elide the Author fields if the Author == Committer?
> That would keep a lean format when when the individuals are the same.
> For that suggestion, I think you would always show the two Commit fields
> ("Committer" and "CommitDate") and only show "Author" and "AuthorDate"
> if Author != Committer?
I discussed this a bit with John on IRC, but for the benefit of the list:
We expect Author == Committer will be common, and the commit date is
probably the more interesting date. In addition, committer will always
be someone@FreeBSD.org, so what about if we take John's suggestion for
Date, and use the author name, appending (via /committer/) if it's not
the author?
Thus, for the example above:
Author: John Baldwin <jhb@FreeBSD.org> (via rlibby)
Date: 2020-12-31 19:56:33 +0000
This is nice and concise while conveying all useful information, IMO.
This would work identically for MFCs of commits made by other
committers, as well as committing changes submitted by 3rd parties.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2BURCr1aW4A_8VbZaXFUsfVTvm92Mco5nqUGmRXDOJiKA>