Date: Mon, 18 Mar 2019 12:16:16 +0100 From: Jan Beich <jbeich@FreeBSD.org> To: Graham Perrin <grahamperrin@gmail.com> Cc: Charlie Li <ml+freebsd@vishwin.info>, gecko@freebsd.org Subject: Re: Building (deleted) Waterfox 56.2.8: error: missing documentation for macro Message-ID: <lg1c-qvpb-wny@FreeBSD.org> In-Reply-To: <340c1855-c3c7-af5d-a375-9e95bd72864f@gmail.com> (Graham Perrin's message of "Mon, 18 Mar 2019 08:15:52 %2B0000") References: <496db844-cb0b-1b53-b498-beec9324b9c0@gmail.com> <mult-tqlp-wny@FreeBSD.org> <1a8a2cd4-fce2-5dca-ec4a-a417d783f56a@vishwin.info> <340c1855-c3c7-af5d-a375-9e95bd72864f@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Graham Perrin <grahamperrin@gmail.com> writes: > On 17/03/2019 19:54, Charlie Li wrote: > >> On 17/03/2019 12:25, Jan Beich wrote: >> >>> =E2=80=A6 >>> >>> Looks like a regression from Rust 1.33 update. >>> >>> Either remove missing_docs from #![deny(...)] lines (or lines=20 > themselves) >>> for each one that triggers error (no need to bother with unused ones) or >>> add MOZ_OPTIONS+=3D--disable-stylo to Makefile.local. >>> >>> =E2=80=A6 >> >> I simply followed the tip given in Mozilla bug 1521249 (remove >> `#![deny(missing_docs)]`), and have been running with it since we >> updated our lang/rust to 1.33: >> https://bugzilla.mozilla.org/show_bug.cgi?id=3D1521249#c36 >> #![deny(missing_docs)] should probably be killed in favor of -Dwarnings after https://bugzilla.mozilla.org/show_bug.cgi?id=3D1513009 It's usually a waste of time to fix doc-related warnigs on release branches. Rust compiler upgrades just make this more obvious. > > Thank you both. > > In my fork: <https://github.com/grahamperrin/Waterfox/pull/7/files>; =E2= =80=93 > at a glance, does that look OK? > > I'm unsure about > <https://github.com/grahamperrin/Waterfox/pull/7/files#diff-df8dc4c48927e= 0bc43931d04bb5b9d9aR161>, > should that line be left as was? > > =C2=A0#[deny(missing_docs)] > > (No exclamation mark.) If the line doesn't break build, leave it as is. See also https://doc.rust-lang.org/reference/attributes.html In general, try to document error you're fixing or working around in the commit message as the rationale. And discussions like this one are only useful to reference as meta information in PR description, not in commits.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?lg1c-qvpb-wny>