Date: Wed, 7 Oct 1998 02:10:44 -0400 (EDT) From: Ion Badulescu <ionut@moisil.cs.columbia.edu> To: Doug Ledford <dledford@dialnet.net> Cc: aic7xxx@FreeBSD.ORG Subject: Re: host unique_id for aic7xxx driver Message-ID: <Pine.LNX.4.02.9810070205360.272-100000@moisil.cs.columbia.edu> In-Reply-To: <361AE85E.F69DD912@dialnet.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 6 Oct 1998, Doug Ledford wrote:
> Elgin Lee wrote:
> > --- linux/drivers/scsi/aic7xxx.c.pre15 Sat Oct 3 02:03:19 1998
> > +++ linux/drivers/scsi/aic7xxx.c Sat Oct 3 02:08:04 1998
> > @@ -7452,6 +7452,7 @@
> > host->n_io_port = 0xFF;
> > host->base = (unsigned char *) p->mbase;
> > host->irq = p->irq;
> > + host->unique_id = host->host_no;
> > if (p->features & AHC_WIDE)
> > {
> > host->max_id = 16;
>
> Something similar, but not identical, has been added for the pre16 code.
Careful though, especially if the final 5.1 driver makes it into 2.0.36,
as Alan's comments seem to imply. Such a change _will_ break every
existing installation that's using scsidev (with one controller, so there
is no problem). Better to keep unique_id = 0 for the first controller and
give non-zero values to the other controllers.
For the 2.1 kernel it doesn't matter, it breaks scsidev anyway by
reordering the controllers in proc_fs.h. But for 2.0 it's important to
follow the principle of the least surprise.
Ion
--
It is better to keep your mouth shut and be thought a fool,
than to open it and remove all doubt.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-aic7xxx" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.LNX.4.02.9810070205360.272-100000>