Date: Tue, 06 Mar 2001 17:27:37 +0100 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Maxim Sobolev <sobomax@FreeBSD.ORG> Cc: Warner Losh <imp@harmony.village.org>, igorr@crosswinds.net, freebsd-current@FreeBSD.ORG Subject: Re: Correct size of kinfo_proc Message-ID: <9377.983896057@critter> In-Reply-To: Your message of "Tue, 06 Mar 2001 18:23:29 %2B0200." <3AA50F01.6560C34A@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <3AA50F01.6560C34A@FreeBSD.org>, Maxim Sobolev writes: >Warner Losh wrote: > >> In message <20010228161009.B14235@linux.rainbow> Igor Robul writes: >> : On Wed, Feb 28, 2001 at 03:00:48PM +0200, Maxim Sobolev wrote: >> : > Hi Poul, >> : > >> : > In revision 1.31 of src/sys/sys/user.h you have added new ki_layout field to >> : > kinfo_proc structure, but forgot to increase KINFO_PROC_SIZE from 644 to 648. >> : > Please correct. >> : Why don't use sizeof() insead of hardcoding numbers? >> >> Because KINFO_PROC_SIZE is part of the ABI. Changes to its size are >> always wrong, in that they break the ABI. The checks are there to >> tell us when the ABI has been broken. > >Well, we are now well informed about this, could we just fix sys/sys/user.h to match >relity (credit goes to phk for broking it and ignoring my posts completely)? I've been kind of waiting for -current to actually work again. I hate commiting to -current when it's börked. Yes, fix it in <sys/user.h> for now, or better, do the right thing with version numbers. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9377.983896057>