Date: Sat, 24 Mar 2001 19:38:57 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Julian Elischer <julian@elischer.org> Cc: John Baldwin <jhb@FreeBSD.ORG>, Archie Cobbs <archie@dellroad.org>, arch@FreeBSD.ORG Subject: Re: Critical Regions Round II Message-ID: <Pine.BSF.4.21.0103241928310.26714-100000@besplex.bde.org> In-Reply-To: <3ABC105D.E01C0842@elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 23 Mar 2001, Julian Elischer wrote:
> John Baldwin wrote:
> > Archie said:
> > > Shouldn't these be, e.g.,
> > >
> > > i386_disable_intr(), i386_enable_intr()
> > >
> > > and
> > >
> > > ia64_enable_intr(), ia64_disable_intr()
> > No, this code should not be used outside of sys/${MACHINE_ARCH}, which is
> > mostly how things were (aside from broken things like the joy driver) before
> > SMPng.
>
> I think the names should include either md_ or I386_ as a leadin so that people
> who are 'copying' to make their own drivers a made fully aware
> of what is going on.
The MD names should simply be accessible in MI code. There are
currently too many of them in <machine/*.h>. A few broken drivers
access MD interfaces directly: grepping for 'include.*i386/' gives:
dev/aha/aha_mca.c:#include <i386/isa/isa_dma.h>
dev/ar/if_ar_isa.c:#include <i386/isa/ic/hd64570.h>
dev/ar/if_ar_isa.c:#include <i386/isa/if_ar.h>
dev/ar/if_ar_isa.c:#include <i386/isa/if_arregs.h>
dev/asr/asr.c:#include <i386/include/vmparam.h>
dev/asr/i2oadptr.h:# include "i386/pci/i2omsg.h"
dev/asr/i2obscsi.h:# include "i386/pci/i2omsg.h" /* Include the Base Message file */
dev/asr/i2oexec.h:# include "i386/pci/i2omsg.h" /* Include the Base Message file */
dev/asr/i2oexec.h:# include "i386/pci/i2outil.h"
dev/asr/i2omsg.h:# include "i386/pci/i2otypes.h"
dev/asr/i2otypes.h:# include "i386/pci/i2odep.h"
dev/asr/i2outil.h:# include "i386/pci/i2omsg.h" /* Include the Base Message file */
dev/asr/osd_util.h:# include "i386/isa/dpt_osd_defs.h"
dev/asr/osd_util.h:# include "i386/isa/dpt_osd_defs.h"
dev/asr/sys_info.h:# include "i386/isa/dpt_osd_util.h"
dev/asr/sys_info.h:# include "i386/isa/dpt_osd_util.h"
dev/buslogic/bt_mca.c:#include <i386/isa/isa_dma.h>
dev/ct/bshw_machdep.c:#include <i386/Cbus/dev/ct/bshwvar.h>
dev/ct/bshw_machdep.c:#include <i386/Cbus/dev/ct/ctvar.h>
dev/ct/bshw_machdep.c:#include <i386/Cbus/dev/scsi_low.h>
dev/ct/bshw_machdep.c:#include <i386/isa/ic/wd33c93.h>
dev/ct/ct.c:#include <i386/Cbus/dev/ct/ctvar.h>
dev/ct/ct.c:#include <i386/Cbus/dev/scsi_low.h>
dev/ct/ct.c:#include <i386/isa/ic/wd33c93.h>
dev/ct/ct_isa.c:#include <i386/Cbus/dev/ct/bshwvar.h>
dev/ct/ct_isa.c:#include <i386/Cbus/dev/ct/ctvar.h>
dev/ct/ct_isa.c:#include <i386/Cbus/dev/scsi_low.h>
dev/ct/ct_isa.c:#include <i386/isa/ic/wd33c93.h>
dev/ct/ctvar.h:#include <i386/Cbus/dev/ct/ct_machdep.h>
dev/dgb/dgb.c:#include <i386/isa/isa_device.h>
dev/dgb/dgm.c:#include <i386/isa/isa_device.h>
dev/dpt/dpt_control.c:#include <i386/include/cputypes.h>
dev/ep/if_ep_isa.c:#include <i386/isa/elink.h>
dev/fe/if_fe.c:#include <i386/isa/ic/mb86960.h>
dev/fe/if_fe_cbus.c:#include <i386/isa/ic/mb86960.h>
dev/fe/if_fe_isa.c:#include <i386/isa/ic/mb86960.h>
dev/fe/if_fe_pccard.c:#include <i386/isa/ic/mb86960.h>
dev/ie/if_ie.c:#include <i386/isa/elink.h>
dev/ie/if_ie.c:#include <i386/isa/ic/i82586.h>
dev/ie/if_ie.c:#include <i386/isa/icu.h>
dev/ie/if_ie.c:#include <i386/isa/isa_device.h>
dev/lnc/if_lnc_pc98.c:#include <i386/isa/isa_device.h>
dev/ncv/ncr53c500.c:#include <i386/Cbus/dev/ncr53c500hw.h>
dev/ncv/ncr53c500.c:#include <i386/Cbus/dev/ncr53c500hwtab.h>
dev/ncv/ncr53c500.c:#include <i386/Cbus/dev/ncr53c500reg.h>
dev/ncv/ncr53c500.c:#include <i386/Cbus/dev/ncr53c500var.h>
dev/ncv/ncr53c500.c:#include <i386/Cbus/dev/scsi_low.h>
dev/ncv/ncr53c500_pccard.c:#include <i386/isa/isa_device.h>
dev/nsp/nsp.c:#include <i386/Cbus/dev/nspreg.h>
dev/nsp/nsp.c:#include <i386/Cbus/dev/nspvar.h>
dev/nsp/nsp.c:#include <i386/Cbus/dev/scsi_low.h>
dev/nsp/nsp_pccard.c:#include <i386/isa/isa_device.h>
dev/pdq/pdq_ifsubr.c:#include <i386/isa/isavar.h>
dev/stg/tmc18c30.c:#include <i386/Cbus/dev/scsi_low.h>
dev/stg/tmc18c30.c:#include <i386/Cbus/dev/tmc18c30reg.h>
dev/stg/tmc18c30.c:#include <i386/Cbus/dev/tmc18c30var.h>
dev/stg/tmc18c30_pccard.c:#include <i386/isa/isa_device.h>
Bruce
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0103241928310.26714-100000>