Date: Mon, 13 May 2002 06:35:21 -0700 From: Alfred Perlstein <alfred@FreeBSD.org> To: Dan Eischen <eischen@vigrid.com> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc_r/uthread pthread_private.h uthread_attr_setguardsize.cuthread_init.c uthread_stack.c Message-ID: <20020513133521.GV90188@elvis.mu.org> In-Reply-To: <3CDF9CDB.BF0E65F5@vigrid.com> References: <200205130758.g4D7wFo67279@freefall.freebsd.org> <3CDF9CDB.BF0E65F5@vigrid.com>
next in thread | previous in thread | raw e-mail | index | archive | help
* Dan Eischen <eischen@vigrid.com> [020513 04:55] wrote: > Alfred Perlstein wrote: > > > > alfred 2002/05/13 00:58:15 PDT > > > > Modified files: > > lib/libc_r/uthread pthread_private.h > > uthread_attr_setguardsize.c > > uthread_init.c uthread_stack.c > > Log: > > Don't use PAGE_SIZE in userland, instead use getpagesize(), this is to > > allow running on other arches when the instructions are supported but > > the page size granularity is not. > > This adds namespace pollution to libc_r. Please fix and precede externals > with underscores. You should be able to do 'nm libc_r.so.5 | grep " T "' > and not see anything that isn't preceded with underscores. Ok, will do. -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' Tax deductible donations for FreeBSD: http://www.freebsdfoundation.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020513133521.GV90188>