Date: Sat, 15 Jul 2023 09:31:45 -0800 From: Rob Wing <rob.fx907@gmail.com> To: Matthew Grooms <mgrooms@shrew.net> Cc: "virtualization@freebsd.org" <virtualization@freebsd.org> Subject: Re: BHYVE SNAPSHOT image format proposal Message-ID: <CAF3%2Bn_cPr0=Z-KbN9R6BqxhcQrhckUqtoqg7LN=dUowAr64sRg@mail.gmail.com> In-Reply-To: <3a037482-2e6c-667f-1979-d5b612e506ec@shrew.net> References: <67FDC8A8-86A6-4AE4-85F0-FF7BEF9F2F06@gmail.com> <6b98da58a5bd8e83bc466efa20b5a900298210aa.camel@FreeBSD.org> <8387AC83-6667-48E5-A3FA-11475EA96A5F@gmail.com> <d92db9bfbea181d6eb9d57b579d67e8e118ef4de.camel@FreeBSD.org> <986A83D8-E0E0-4030-9369-A5B3500E27C6@gmail.com> <79fabe94-b800-c713-48ea-518da1f74e4d@shrew.net> <CAF3%2Bn_cc5ZpGsKCff%2Bu-rSjnJn%2BN1jdu9KW0Y5b6n_TieMsfng@mail.gmail.com> <3973013d-c183-360f-d7ca-ca822859c23d@shrew.net> <CAF3%2Bn_czuJ=B2mok2wh7OPvkzMz7%2B9KRG8_NuCyEL9SMFLt6tw@mail.gmail.com> <3a037482-2e6c-667f-1979-d5b612e506ec@shrew.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--00000000000086fca1060089f0d4 Content-Type: text/plain; charset="UTF-8" On Saturday, July 15, 2023, Matthew Grooms <mgrooms@shrew.net> wrote: > > > We'll overlook the fact that it does attempt to consolidate files ( 2 vs 3 > ) and that there's no feedback requesting further consolidation after being > open for two years, but noted. You may as well abandon https://reviews.freebsd.org/D29262, for these reasons alone: - JSON doesn't support storing binary data - a snapshot should be contained in a single file The UPB patch addresses the above. Vitaliy's patch does nothing to address > any of it. If one is going to be proposed as an alternative to the other, > it better solve the same problems as then some. The UBP patch is not an alternative - show me another hypervisor that uses JSON as their snapshot format. > The silence is real. No, it's not. I've given you feedback multiple times. --00000000000086fca1060089f0d4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div><br></div>On Saturday, July 15, 2023, Matthew Grooms <<a href=3D"ma= ilto:mgrooms@shrew.net">mgrooms@shrew.net</a>> wrote:<blockquote class= =3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd= ing-left:1ex"> <br> We'll overlook the fact that it does attempt to consolidate files ( 2 v= s 3 ) and that there's no feedback requesting further consolidation aft= er being open for two years, but noted.</blockquote><div><br></div><div>You= may as well abandon=C2=A0<a href=3D"https://reviews.freebsd.org/D29262">ht= tps://reviews.freebsd.org/D29262</a>, for these reasons alone:</div><div><b= r></div><div>- JSON doesn't support storing binary data</div><div>- a s= napshot should be contained in a single file</div><div><br></div><blockquot= e class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc sol= id;padding-left:1ex"> The UPB patch addresses the above. Vitaliy's patch does nothing to addr= ess any of it. If one is going to be proposed as an alternative to the othe= r, it better solve the same problems as then some.</blockquote><div><br></d= iv><div>The UBP patch is not an alternative - show me another hypervisor th= at uses JSON as their snapshot format.</div><div>=C2=A0<br></div><blockquot= e class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc sol= id;padding-left:1ex"> The silence is real.</blockquote><div><br></div><div>No, it's not. I= 9;ve given you feedback multiple times.</div> --00000000000086fca1060089f0d4--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF3%2Bn_cPr0=Z-KbN9R6BqxhcQrhckUqtoqg7LN=dUowAr64sRg>