Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 30 Sep 2008 08:19:54 -0400
From:      Robert Noland <rnoland@FreeBSD.org>
To:        "Paul B. Mahol" <onemda@gmail.com>
Cc:        freebsd-x11 <freebsd-x11@freebsd.org>
Subject:   Re: [CFT] intel g33 & g45
Message-ID:  <1222777194.1683.29.camel@wombat.2hip.net>
In-Reply-To: <3a142e750809300245w8d9e720w5da705ced21aec6a@mail.gmail.com>
References:  <1222735160.1683.6.camel@wombat.2hip.net> <3a142e750809300245w8d9e720w5da705ced21aec6a@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help

[-- Attachment #1 --]
On Tue, 2008-09-30 at 11:45 +0200, Paul B. Mahol wrote:
> On 9/30/08, Robert Noland <rnoland@freebsd.org> wrote:
> > Attached is a patch to agp_i810 that should correctly handle that g33 /
> > q33 intel chipsets.  It also should add support for the g45 series chips
> > (x4500).  I don't have any of this hardware to test, so I need some
> > feedback, either way.
> >
> > This also changes the 945 code slightly, so that is also worth testing.
> > I am running on a 945gm now.
> >
> > This is against -CURRENT, but may apply to STABLE as well.
> 
> Patching doesnt work on CURRENT for me:
> 
> # cd /sys/dev/agp
> # patch -C < /home/paul/src/freebsd/agp_i810-g33-g45.patch
> Hmm...  Looks like a unified diff to me...
> The text leading up to this was:
> --------------------------
> |Index: agp_i810.c
> |===================================================================
> |--- agp_i810.c (revision 183193)
> |+++ agp_i810.c (working copy)
> --------------------------
> Patching file agp_i810.c using Plan A...
> Hunk #1 failed at 70.
> Hunk #2 failed at 134.
> Hunk #3 failed at 155.
> Hunk #4 failed at 485.
> Hunk #5 failed at 501.
> Hunk #6 failed at 512.
> Hunk #7 failed at 530.
> Hunk #8 failed at 567.
> Hunk #9 failed at 657.
> Hunk #10 failed at 674.
> 10 out of 10 hunks failed--saving rejects to agp_i810.c.rej
> Hmm...  The next patch looks like a unified diff to me...
> The text leading up to this was:
> --------------------------
> |Index: agpreg.h
> |===================================================================
> |--- agpreg.h   (revision 183193)
> |+++ agpreg.h   (working copy)
> --------------------------
> Patching file agpreg.h using Plan A...
> Hunk #1 failed at 215.
> Hunk #2 failed at 259.
> 2 out of 2 hunks failed--saving rejects to agpreg.h.rej
> done

wombat% pwd
/home/rnoland/freebsd/src/sys/dev/agp
wombat% patch -C < ~/agp_i810-g33-g45.patch 
Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|Index: agp_i810.c
|===================================================================
|--- agp_i810.c (revision 183193)
|+++ agp_i810.c (working copy)
--------------------------
Patching file agp_i810.c using Plan A...
Hunk #1 succeeded at 70.
Hunk #2 succeeded at 134.
Hunk #3 succeeded at 155.
Hunk #4 succeeded at 485.
Hunk #5 succeeded at 501.
Hunk #6 succeeded at 512.
Hunk #7 succeeded at 530.
Hunk #8 succeeded at 567.
Hunk #9 succeeded at 657.
Hunk #10 succeeded at 674.
Hmm...  The next patch looks like a unified diff to me...
The text leading up to this was:
--------------------------
|Index: agpreg.h
|===================================================================
|--- agpreg.h   (revision 183193)
|+++ agpreg.h   (working copy)
--------------------------
Patching file agpreg.h using Plan A...
Hunk #1 succeeded at 215.
Hunk #2 succeeded at 259.
done

I just checked it against my current cvs checkout of src.  Maybe it was
corrupted by the mailer.  I'll put it up at
http://people.freebsd.org/~rnoland/agp_i810-g33-g45.patch

robert.

[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (FreeBSD)

iEYEABECAAYFAkjiGWoACgkQM4TrQ4qfROOZ+ACfXjIEE+UJYLxL53qbCfIdNBmI
+lIAn3Ov7Ylsue+lkqhSQbmQHn+Q1E5V
=bBcN
-----END PGP SIGNATURE-----

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1222777194.1683.29.camel>