Date: Wed, 2 Jun 2004 06:43:40 -0700 From: Kris Kennaway <kris@obsecurity.org> To: Oliver Eikemeier <eikemeier@fillmore-labs.com> Cc: Kris Kennaway <kris@obsecurity.org> Subject: Re: INDEX patch Message-ID: <20040602134340.GA55881@xor.obsecurity.org> In-Reply-To: <40BDD8B6.80103@fillmore-labs.com> References: <20040602121648.GA51625@xor.obsecurity.org> <40BDCC4B.9000708@fillmore-labs.com> <20040602132149.GA55452@xor.obsecurity.org> <40BDD8B6.80103@fillmore-labs.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--r5Pyd7+fXNt84Ff3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 02, 2004 at 03:40:06PM +0200, Oliver Eikemeier wrote: > Kris Kennaway wrote: >=20 > >On Wed, Jun 02, 2004 at 02:47:07PM +0200, Oliver Eikemeier wrote: > > > >>Kris Kennaway wrote: > >> > >> > >>>A previous commit to bsd.port.mk broke the reporting of missing > >>>dependencies from 'make index'. This patch restores it (and makes > >>>these errors fatal). I plan to commit it soon. > >>> > >>>Kris > >> > >>May I suggest the following patch: > >> > >>- check for existence of perl (cf. my RFC on ports-developers) > >>- enables the use of `env PATH=3D /usr/bin/make describe' (nice for tes= ting) > > > >Nice idea, but running this test 11000 times is suboptimal :-) >=20 > Because test is a sh-builtin, and the file system should cache this=20 > information > I don't expect to see any difference. Especially since spawning perl 1100= 0=20 > times > is more than suboptimal ;) You didn't mean this serious, did you? I did, because I care about small pessimizations of the INDEX build. Sometimes they're not small. Did you benchmark it? Kris --r5Pyd7+fXNt84Ff3 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAvdmMWry0BWjoQKURArURAKCIoD2cMCUk4VGOORGjpQbIerXvQgCglEmf uSc62ry7nItBaD61lc+JbOc= =7fcS -----END PGP SIGNATURE----- --r5Pyd7+fXNt84Ff3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040602134340.GA55881>