Date: Sun, 6 Nov 2016 12:41:54 -0700 From: Sean Bruno <sbruno@freebsd.org> To: Michael Tuexen <tuexen@freebsd.org>, freebsd-scsi@freebsd.org Cc: scottl@freebsd.org Subject: Re: mpt driver issue? Message-ID: <e9698b93-11e6-530a-1d27-ef45706eae66@freebsd.org> In-Reply-To: <4398FA07-AABF-441E-A412-42BABCD59444@freebsd.org> References: <CA9B9B19-5311-4A4E-87ED-8771C1000BEC@freebsd.org> <4398FA07-AABF-441E-A412-42BABCD59444@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--gmUQojcTriqElfHw5E40dTo5GAuJHxakc
Content-Type: multipart/mixed; boundary="rVBg9g1EiuJo5BOrG37RuxlH46a35N2eu";
protected-headers="v1"
From: Sean Bruno <sbruno@freebsd.org>
To: Michael Tuexen <tuexen@freebsd.org>, freebsd-scsi@freebsd.org
Cc: scottl@freebsd.org
Message-ID: <e9698b93-11e6-530a-1d27-ef45706eae66@freebsd.org>
Subject: Re: mpt driver issue?
References: <CA9B9B19-5311-4A4E-87ED-8771C1000BEC@freebsd.org>
<4398FA07-AABF-441E-A412-42BABCD59444@freebsd.org>
In-Reply-To: <4398FA07-AABF-441E-A412-42BABCD59444@freebsd.org>
--rVBg9g1EiuJo5BOrG37RuxlH46a35N2eu
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
On 11/06/16 10:54, Michael Tuexen wrote:
> Dear all,
>=20
> it was suggested on current@ to forward this to freebsd-scsi@
>=20
> The problem shows up since r308268 and it looks like an issue
> in the mpt driver...
>=20
> Best regards
> Michael
I don't see any *obvious* reason that we should hold the mpt lock here.
It looks ok to just drop it.
sean
Index: sys/dev/mpt/mpt.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- sys/dev/mpt/mpt.c (revision 308345)
+++ sys/dev/mpt/mpt.c (working copy)
@@ -2284,9 +2284,7 @@
mpt_lprt(mpt, MPT_PRT_DEBUG, "doorbell req =3D %s\n",
mpt_ioc_diag(mpt_read(mpt, MPT_OFFSET_DOORBELL)));
- MPT_LOCK(mpt);
error =3D mpt_configure_ioc(mpt, 0, 0);
- MPT_UNLOCK(mpt);
return (error);
}
--rVBg9g1EiuJo5BOrG37RuxlH46a35N2eu--
--gmUQojcTriqElfHw5E40dTo5GAuJHxakc
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQF8BAEBCgBmBQJYH4eCXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRCQUFENDYzMkU3MTIxREU4RDIwOTk3REQx
MjAxRUZDQTFFNzI3RTY0AAoJEBIB78oecn5kBl8H+wXvTw6UNz60CCSQKDBXyutj
ZfdbbSwf1clyM3dfUTPlVY87cSS5gnaNE2D4pFgnb0uum+5pH4YC+M9or/eSHIHp
yw/FLvwNZS3uWk4meAq1s+9hEXnUHvsFiry9cssklrLtKS2bn8BhDCzJdPnq58U5
oOn74eNUMep5EeFLtFjkX3jEAuZBghQzcnymCHftcaNGM4PXIi5PVKOMnLiiyWkS
UaS4SYIrH9TNNnjYCFQ56ScE3zz5Gnl8Q+hDk20r37Uk1QQAkR+bzkeaPrVD+Qu6
IFjF5U0mp7AQ+md2DbcfBJN3gDTHc94gHMBbgFjXbkfgDcrQGAoagh9HNWG/Vpw=
=qWMX
-----END PGP SIGNATURE-----
--gmUQojcTriqElfHw5E40dTo5GAuJHxakc--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e9698b93-11e6-530a-1d27-ef45706eae66>