Date: Sat, 23 Sep 2006 20:21:21 +0400 From: Stanislav Sedov <stas@FreeBSD.org> To: Rainer Alves <rainer.alves@gmail.com> Cc: ports@freebsd.org, Kevin Oberman <oberman@es.net> Subject: Re: avifile will not compile on -current Message-ID: <20060923202121.6da03730@localhost> In-Reply-To: <45146712.1050402@gmail.com> References: <20060922211055.E8B584506A@ptavv.es.net> <45146712.1050402@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_Pb10jApYXwZJwuq/SXWcczM
Content-Type: text/plain; charset=KOI8-R
Content-Transfer-Encoding: quoted-printable
On Fri, 22 Sep 2006 19:43:30 -0300
Rainer Alves <rainer.alves@gmail.com> mentioned:
> Kevin Oberman wrote:
> > avifile has not built on current since the update of gcc to the latest
> > 3.4.6 fixes back on Aug. 25.
>=20
> It also doesn't compile here, for 2 reasons:
> 1) since `pcvt` was removed from CURRENT around May or so, avifile no=20
> longer finds the header "pcvt_ioctl.h" and the build breaks here:
>=20
> cc -DHAVE_CONFIG_H -I. -I. -I../../include -I/usr/local/include=20
> -I/usr/local/include -I/usr/X11R6/include -D_GETOPT_H -Wall -Wno-unused=20
> -I../../include -O2 -fno-strict-aliasing -pipe -D_LARGEFILE_SOURCE=20
> -D_FILE_OFFSET_BITS=3D64 -pipe -c ports.c -fPIC -DPIC -o .libs/ports.o
> In file included from ports.c:73:
> sysdep/pci_freebsd.c:11:32: machine/pcvt_ioctl.h: No such file or directo=
ry
>=20
> The fix is trivial: the replacement of "machine/pcvt_ioctl.h" by=20
> "sys/kbio.h" (which also contains KDENABIO from the defunct pcvt).
>=20
>=20
> 2) As for the error you pointed out, here is a quick patch which fixes=20
> things for me:
>=20
> --- ReadFile.cpp.orig Fri Sep 22 19:40:20 2006
> +++ ReadFile.cpp Fri Sep 22 19:41:19 2006
> @@ -8,7 +8,7 @@
>=20
> AVM_BEGIN_NAMESPACE;
>=20
> -avm::IReadFile::~IReadFile() {}
> +IReadFile::~IReadFile() {}
>=20
> class ReadFile: public IReadFile
> {
> @@ -125,7 +125,7 @@
> };
>=20
>=20
> -avm::IReadFile* avm::CreateReadFile(const char* name, unsigned int flags)
> +IReadFile* CreateReadFile(const char* name, unsigned int flags)
> {
> ReadFile* r =3D new ReadFile(name, flags);
> return r;
>=20
>=20
Committed.
Thanks for a patch.
--=20
Stanislav Sedov <stas@FreeBSD.org> [[=F2=CF=D3=D3=C9=
=D1, =ED=CF=D3=CB=D7=C1]]
PGP id: 0xEB269581 http://people.freebsd.org/~stas/stas.key.asc
--Sig_Pb10jApYXwZJwuq/SXWcczM
Content-Type: application/pgp-signature; name=signature.asc
Content-Disposition: attachment; filename=signature.asc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (FreeBSD)
iD8DBQFFFV8BK/VZk+smlYERAraIAJ9D+eb6LURxBIru0UvgryQDx/WlwwCfcSXV
SNstdkUoTlsmKWJZOD5ILGo=
=S/P8
-----END PGP SIGNATURE-----
--Sig_Pb10jApYXwZJwuq/SXWcczM--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060923202121.6da03730>