Date: Mon, 24 Dec 2007 14:44:20 -0500 From: Joe Marcus Clarke <marcus@FreeBSD.org> To: Andriy Gapon <avg@icyb.net.ua> Cc: kde@FreeBSD.org, freebsd-gnome@FreeBSD.org Subject: Re: multislot cardreader and hald Message-ID: <1198525460.34216.30.camel@shumai.marcuscom.com> In-Reply-To: <476FE856.1080702@icyb.net.ua> References: <476A8A01.3040202@icyb.net.ua> <op.t3m7k1qp9aq2h7@mezz.mezzweb.com> <476A9D99.2050804@icyb.net.ua> <op.t3m8cgek9aq2h7@mezz.mezzweb.com> <476BAAB0.9030303@icyb.net.ua> <op.t3o3zlvn9aq2h7@mezz.mezzweb.com> <476BC09A.8070300@freebsd.org> <476FC2EC.2060804@icyb.net.ua> <476FE856.1080702@icyb.net.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-Pacd3K7xS0xhVBwV41+B Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Mon, 2007-12-24 at 19:11 +0200, Andriy Gapon wrote: > on 24/12/2007 16:32 Andriy Gapon said the following: > > on 21/12/2007 15:33 Joe Marcus Clarke said the following: > >> Disc media is treated differently than USB media. USB umass devices a= re > >> assumed to have media. This is part of the issue with the card reader > >> (floppy drives behave the same way). > >=20 > > Isn't this a bad assumption? >=20 > Attached is a patch that attempts to address removable storage devices > (that are not CD-ROMs) attached either via SCSI or via USB. The purpose > is to do "gentler" probing of media presence than that done by OS in > response to open(2). > I employed one hack in the code to avoid device being open()-ed if > cam_open_device() fails, but this was "just in case", not sure if it was > really needed. >=20 > The patch works very well for me, especially in tandem with the patch > for SCSI verboseness that I posted to -stable and -scsi. Committed with a change to check that the driver is one of da, sa, or cd when the bus type is USB (we now have ATA USB support as well). I also changed the cdrom variable name to scsi_device as we aren't necessarily dealing with cdrom devices in all cases. The functionality should not be changed, though. Thanks for doing this. Joe --=20 Joe Marcus Clarke FreeBSD GNOME Team :: gnome@FreeBSD.org FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome --=-Pacd3K7xS0xhVBwV41+B Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQBHcAwTb2iPiv4Uz4cRAjReAJoCZBPPAeq42o+XHFVuqRWu7gih+gCglxBw vLzJbuS1H1WPnfzzSoaqfTA= =gv8W -----END PGP SIGNATURE----- --=-Pacd3K7xS0xhVBwV41+B--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1198525460.34216.30.camel>