Date: Wed, 20 Feb 2008 13:25:00 -0500 From: Ken Smith <kensmith@cse.Buffalo.EDU> To: Mark Peek <mp@FreeBSD.org> Cc: Rui Paulo <rpaulo@fnop.net>, freebsd-current@FreeBSD.org, re@FreeBSD.org, Anton Yuzhaninov <citrin@citrin.ru> Subject: Re: tcsh in current-8.0 coredump Message-ID: <1203531900.99240.16.camel@bauer.cse.buffalo.edu> In-Reply-To: <47BC63BC.4080003@FreeBSD.org> References: <47BB4E5D.7010505@citrin.ru> <7F7C8315-AB96-425E-B942-0DB55BFDBCF3@FreeBSD.org> <47BC2AAB.5090605@citrin.ru> <A82E7FE0-0551-423A-9684-0C48781A1561@fnop.net> <47BC63BC.4080003@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-6fEk2p1qMiSAHeVbY0EQ Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Wed, 2008-02-20 at 09:30 -0800, Mark Peek wrote: > On 2/20/08 8:05 AM, Rui Paulo wrote: > >=20 > > On Feb 20, 2008, at 1:27 PM, Anton Yuzhaninov wrote: > >=20 > >> On 20.02.2008 4:56, Rui Paulo wrote: > >>> On Feb 19, 2008, at 9:47 PM, Anton Yuzhaninov wrote: > >>>> Problem was described here: > >>>> http://docs.freebsd.org/cgi/mid.cgi?131632274.20070319100945 > >>>> http://mx.gw.com/pipermail/tcsh-bugs/2007-March/000481.html > >>>> > >>>> This was fixed for RELENG_7: > >>>> > >>>> http://www.freebsd.org/cgi/cvsweb.cgi/src/contrib/tcsh/sh.lex.c > >>>> Revision 1.1.1.8 (vendor branch): download - view: text, markup,=20 > >>>> annotated - select for diffs > >>>> Tue Apr 3 15:51:53 2007 UTC (10 months, 2 weeks ago) by mp > >>>> Branches: ZOULAS, MAIN > >>>> CVS tags: tcsh_6_15p1, RELENG_7_BP, RELENG_7_0_BP, RELENG_7_0, RELEN= G_7 > >>>> Diff to: previous 1.1.1.7: preferred, colored > >>>> Changes since revision 1.1.1.7: +2 -1 lines > >>>> > >>>> Import vendor patch to fix postcmd regression in tcsh-6.15.00. > >>>> ------- > >>>> > >>>> But this bug was not fixed in HEAD. > >>>> > >>> Are you sure? I seem to recall this was fixed even before RELENG_7=20 > >>> was tagged. > >> > >> $ cvs up > >> $ cvs diff -r HEAD -r RELENG_7 contrib/tcsh/sh.lex.c > >> Index: contrib/tcsh/sh.lex.c > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > >> RCS file: /home/ncvs/src/contrib/tcsh/sh.lex.c,v > >> retrieving revision 1.1.1.9 > >> retrieving revision 1.1.1.8 > >> diff -u -r1.1.1.9 -r1.1.1.8 > >> --- contrib/tcsh/sh.lex.c 15 Oct 2007 16:54:07 -0000 1.1.1.= 9 > >> +++ contrib/tcsh/sh.lex.c 3 Apr 2007 15:51:53 -0000 1.1.1.= 8 > >> @@ -851,7 +851,8 @@ > >> return (en); > >> } > >> slhs.len =3D 0; > >> - Strbuf_append(&slhs, lhsb.s); > >> + if (lhsb.s !=3D NULL && lhsb.len !=3D 0) > >> + Strbuf_append(&slhs, lhsb.s); > >> Strbuf_terminate(&slhs); > >> if (exclc) > >> en =3D dosub(sc, en, global); > >> > >> As you can see from cvs diff, null pointer check present in RELENG_7.=20 > >> but absent in HEAD > >=20 > > Oh, you are right. This was never MFC'ed, but the log says: > >=20 > > revision 1.1.1.9 > > date: 2007/10/15 16:54:07; author: mp; state: Exp; lines: +1 -2 > > Import two vendor fixes from tcsh-6.15.01 for MFC to 7.0. The fixes are= : > > - Fix pty detection for autologout setting > > - kill `foo` got stuck because sigchld was disabled too soon > >=20 > > Requested by: re > >=20 > > Maybe we should MFC this now. >=20 > That's really odd. I thought RELENG_7 didn't branch until 10/10/2007 but = the=20 > postcmd fix was imported on 4/3/2007. In other words, I thought it was al= ready=20 > in RELENG_7. But CVS still thinks the two are different. I can MFC it whe= never=20 > re@ approves it given we're at 7.0-RC2. >=20 > Mark I *think* the original message above has it correct and you (Mark and Rui) have it reversed. Mark, I think when re@ requested this you might have done the commit straight to RELENG_7 and didn't do HEAD. So as things stand right now this is what's in RELENG_7 and RELENG_7_0: slhs.len =3D 0; if (lhsb.s !=3D NULL && lhsb.len !=3D 0) Strbuf_append(&slhs, lhsb.s); Strbuf_terminate(&slhs); (which I believe is what you want) but this is what's in HEAD: slhs.len =3D 0; Strbuf_append(&slhs, lhsb.s); Strbuf_terminate(&slhs); If I'm wrong about that let me know. Otherwise you don't need approval for what needs to be done from re@, just commit the fix to HEAD whenever you want. --=20 Ken Smith - From there to here, from here to | kensmith@cse.buffalo.edu there, funny things are everywhere. | - Theodore Geisel | --=-6fEk2p1qMiSAHeVbY0EQ Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQBHvHB0/G14VSmup/YRAreuAJ4y84j+DgGbxgjyfE1EG9jdgxnc/QCeJEPU ouYqrcG2JLMoNotJro63Src= =gEpb -----END PGP SIGNATURE----- --=-6fEk2p1qMiSAHeVbY0EQ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1203531900.99240.16.camel>